enable android x86 build

base/base.gypi

 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 {
   'target_defaults': {
     'variables': {
       'base_target': 0,
     },
     'target_conditions': [
@@ skipping 659 matching lines @@
                 ['exclude', '^native_library_linux\\.cc$'],
                 ['exclude', '^process_util_linux\\.cc$'],
                 ['exclude', '^sys_info_linux\\.cc$'],
                 ['exclude', '^sys_string_conversions_linux\\.cc$'],
                 ['exclude', '^worker_pool_linux\\.cc$'],
               ],
             }],
           ],
         }],
         [ 'OS == "android" and _toolset == "target"', {
+          'conditions': [
+            ['target_arch == "ia32"', {
+              'sources/': [

[Paweł Hajdan Jr., 2012/04/27 06:56:19]

nit: Why don't you just use 'sources!' instead?

[Wei James, 2012/04/27 08:59:05]

this code is just copied from above line#658. do you mean "sources"? because I
would like to include the files for target build just like linux host build. I
tested with both "sources" and "sources!", but it seems the files are not
included so there is undefined error when linking. I am not a gyp expert and
cannot find the root cause yet. 

I saw most of the sources in this file use "sources/" style. is it ok to keep it
to be consistent with others? thanks 

[Paweł Hajdan Jr., 2012/04/27 09:40:06]

Ah right, it's "include" so just "sources" please.
It's simpler to use "sources" to include files and "sources!" to exclude them.
I'd rather convert the surrounding code (possibly in a separate CL) instead of
keeping the weird style (maybe someone just didn't know gyp well).

+                ['include', '^atomicops_internals_x86_gcc\\.cc$'],
+              ],
+            }],
+          ],
           'dependencies': [
             'symbolize',
             '../third_party/ashmem/ashmem.gyp:ashmem',
             'base_java',
             'base_jni_headers',
           ],
           'include_dirs': [
             '<(SHARED_INTERMEDIATE_DIR)/base',
           ],
           'link_settings': {
@@ skipping 228 matching lines @@
             'third_party/xdg_mime/xdgmimemagic.c',
             'third_party/xdg_mime/xdgmimemagic.h',
             'third_party/xdg_mime/xdgmimeparent.c',
             'third_party/xdg_mime/xdgmimeparent.h',
           ],
         },
       ],
     }],
   ],
 }