Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Unified Diff: media/video/capture/mac/video_capture_device_mac.mm

Issue 10198016: Fix TODO comments for the mac media capture part (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: fix camelcase style issues Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | media/video/capture/mac/video_capture_device_qtkit_mac.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/video/capture/mac/video_capture_device_mac.mm
diff --git a/media/video/capture/mac/video_capture_device_mac.mm b/media/video/capture/mac/video_capture_device_mac.mm
index b15a810705c6204f8ba5d89d06ed8f9ce8f64bb5..cff39331d09cce5cf2b901c996ee211187a9a1b6 100644
--- a/media/video/capture/mac/video_capture_device_mac.mm
+++ b/media/video/capture/mac/video_capture_device_mac.mm
@@ -16,13 +16,11 @@ void VideoCaptureDevice::GetDeviceNames(Names* device_names) {
// Loop through all available devices and add to |device_names|.
device_names->clear();
- // TODO(mflodman) Return name and id as NSArray* instead of QTCaptureDevice*.
- for (QTCaptureDevice* device in [VideoCaptureDeviceQTKit deviceNames]) {
+ NSDictionary* capture_devices = [VideoCaptureDeviceQTKit deviceNames];
+ for (NSString* key in capture_devices) {
Name name;
- NSString* qt_device_name = [device localizedDisplayName];
- name.device_name = [qt_device_name UTF8String];
- NSString* qt_unique_id = [device uniqueID];
- name.unique_id = [qt_unique_id UTF8String];
+ name.device_name = [[capture_devices valueForKey:key] UTF8String];
+ name.unique_id = [key UTF8String];
device_names->push_back(name);
}
}
« no previous file with comments | « no previous file | media/video/capture/mac/video_capture_device_qtkit_mac.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698