Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1073)

Unified Diff: media/video/capture/mac/video_capture_device_qtkit_mac.mm

Issue 10198016: Fix TODO comments for the mac media capture part (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/video/capture/mac/video_capture_device_qtkit_mac.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/video/capture/mac/video_capture_device_qtkit_mac.mm
diff --git a/media/video/capture/mac/video_capture_device_qtkit_mac.mm b/media/video/capture/mac/video_capture_device_qtkit_mac.mm
index efbee0fd08a36ac19dc42a74155fb423bc30f5f1..055236fecd4763ad91d7f0c374caca3c0488b293 100644
--- a/media/video/capture/mac/video_capture_device_qtkit_mac.mm
+++ b/media/video/capture/mac/video_capture_device_qtkit_mac.mm
@@ -14,8 +14,17 @@
#pragma mark Class methods
-+ (NSArray *)deviceNames {
- return [QTCaptureDevice inputDevicesWithMediaType:QTMediaTypeVideo];
++ (NSDictionary *)deviceNames {
+ NSArray *captureDevices =
+ [QTCaptureDevice inputDevicesWithMediaType:QTMediaTypeVideo];
+ NSMutableDictionary *device_names = [[NSMutableDictionary alloc] init];
mflodman_chromium_OOO 2012/04/25 05:57:09 'device_names' -> 'deviceNames'
mflodman_chromium_OOO 2012/04/25 05:57:09 |device_names| is never released.
+
+ for (QTCaptureDevice* device in captureDevices) {
+ NSString* qt_device_name = [device localizedDisplayName];
mflodman_chromium_OOO 2012/04/25 05:57:09 'qt_device_name' -> 'qtDeviceName'
+ NSString* qt_unique_id = [device uniqueID];
mflodman_chromium_OOO 2012/04/25 05:57:09 'qt_unique_id' -> 'qtUniqueId'
+ [device_names setObject:qt_device_name forKey:qt_unique_id];
+ }
+ return device_names;
}
#pragma mark Public methods
« no previous file with comments | « media/video/capture/mac/video_capture_device_qtkit_mac.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698