Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Issue 10198016: Fix TODO comments for the mac media capture part (Closed)

Created:
8 years, 8 months ago by Jeremy Mao
Modified:
8 years, 8 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Fix TODO comments for the mac media capture part BUG=NONE TEST=media_unittests

Patch Set 1 #

Total comments: 4

Patch Set 2 : fix camelcase style issues #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -11 lines) Patch
M media/video/capture/mac/video_capture_device_mac.mm View 1 chunk +4 lines, -6 lines 0 comments Download
M media/video/capture/mac/video_capture_device_qtkit_mac.h View 1 chunk +2 lines, -3 lines 0 comments Download
M media/video/capture/mac/video_capture_device_qtkit_mac.mm View 1 1 chunk +12 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Jeremy Mao
Hi mflodman, Could you please take a look at this? Thanks Jeremy
8 years, 8 months ago (2012-04-24 15:16:56 UTC) #1
mflodman_chromium_OOO
I'm quite new to objective-c, but added my initial comments. Thanks for looking at this ...
8 years, 8 months ago (2012-04-25 05:57:09 UTC) #2
Jeremy Mao
On 2012/04/25 05:57:09, mflodman wrote: > I'm quite new to objective-c, but added my initial ...
8 years, 8 months ago (2012-04-25 07:39:24 UTC) #3
Jeremy Mao
Hi sherkus, Could you take a look at this when you are free? Thanks & ...
8 years, 8 months ago (2012-04-27 03:01:24 UTC) #4
mflodman_chromium_OOO
LG, but I'm not an objectiv-c expert nor an owner and you would need someone ...
8 years, 8 months ago (2012-04-27 14:03:02 UTC) #5
scherkus (not reviewing)
rubber stamp lgtm again I'm not an obj-c pro here but change looks sane thanks ...
8 years, 8 months ago (2012-04-27 17:48:43 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yujie.mao@intel.com/10198016/4001
8 years, 8 months ago (2012-04-27 22:12:04 UTC) #7
Jeremy Mao
On 2012/04/27 17:48:43, scherkus wrote: > rubber stamp lgtm > > again I'm not an ...
8 years, 8 months ago (2012-04-28 00:11:03 UTC) #8
scherkus (not reviewing)
8 years, 8 months ago (2012-04-28 00:16:48 UTC) #9
Committed as r134403.

Powered by Google App Engine
This is Rietveld 408576698