Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Issue 10198005: Implement handling of binary data in JSON schema compiler (Closed)

Created:
8 years, 8 months ago by cduvall
Modified:
8 years, 8 months ago
CC:
chromium-reviews, pam+watch_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Implement handling of binary data in JSON schema compiler The JSON schema compiler can now handle binary data as an internal type. BUG=123687 TEST=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=133621

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -1 line) Patch
M tools/json_schema_compiler/cc_generator.py View 3 chunks +10 lines, -0 lines 0 comments Download
M tools/json_schema_compiler/cpp_type_generator.py View 2 chunks +3 lines, -1 line 0 comments Download
M tools/json_schema_compiler/cpp_util.py View 1 chunk +1 line, -0 lines 0 comments Download
M tools/json_schema_compiler/model.py View 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
cduvall
Here's the schema compiler changes.
8 years, 8 months ago (2012-04-23 23:47:25 UTC) #1
Yoyo Zhou
LGTM
8 years, 8 months ago (2012-04-23 23:51:50 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cduvall@chromium.org/10198005/1
8 years, 8 months ago (2012-04-23 23:53:55 UTC) #3
commit-bot: I haz the power
Commit queue rejected this change because the description was changed between the time the change ...
8 years, 8 months ago (2012-04-24 01:43:11 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cduvall@chromium.org/10198005/1
8 years, 8 months ago (2012-04-24 01:45:58 UTC) #5
commit-bot: I haz the power
8 years, 8 months ago (2012-04-24 03:17:22 UTC) #6
Change committed as 133621

Powered by Google App Engine
This is Rietveld 408576698