Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(477)

Unified Diff: chrome/browser/chromeos/gdata/gdata_file_system.h

Issue 10198003: gdata: Get rid of GetGDataCacheTmpDirectory() and friends (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix infinite recursion Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/gdata/gdata_file_system.h
diff --git a/chrome/browser/chromeos/gdata/gdata_file_system.h b/chrome/browser/chromeos/gdata/gdata_file_system.h
index 3a093376c8c6dbf5fd286524fead97f7540ba146..c668a8f622b614e03e3d3930eab2b5971408390f 100644
--- a/chrome/browser/chromeos/gdata/gdata_file_system.h
+++ b/chrome/browser/chromeos/gdata/gdata_file_system.h
@@ -357,25 +357,10 @@ class GDataFileSystemInterface {
virtual bool GetFileInfoByPath(const FilePath& gdata_file_path,
GDataFileProperties* properties) = 0;
- // Returns the tmp sub-directory under gdata cache directory, i.e.
- // <user_profile_dir>/GCache/v1/tmp
- virtual FilePath GetGDataCacheTmpDirectory() const = 0;
-
- // Returns the tmp downloads sub-directory under gdata cache directory, i.e.
- // <user_profile_dir>/GCache/v1/tmp/downloads/
- virtual FilePath GetGDataTempDownloadFolderPath() const = 0;
-
- // Returns the tmp documents sub-directory under gdata cache directory, i.e.
- // <user_profile_dir>/GCache/v1/tmp/documents/
- virtual FilePath GetGDataTempDocumentFolderPath() const = 0;
-
- // Returns the pinned sub-directory under gdata cache directory, i.e.
- // <user_profile_dir>/GCache/v1/pinned
- virtual FilePath GetGDataCachePinnedDirectory() const = 0;
-
- // Returns the pinned sub-directory under gdata cache directory, i.e.
- // <user_profile_dir>/GCache/v1/pinned
- virtual FilePath GetGDataCachePersistentDirectory() const = 0;
+ // Returns the sub-directory under gdata cache directory for the given sub
+ // directory type. Example: <user_profile_dir>/GCache/v1/tmp
+ virtual FilePath GetCacheDirectoryPath(
+ GDataRootDirectory::CacheSubDirectoryType sub_dir_type) const = 0;
// Returns absolute path of the file if it were cached or to be cached.
virtual FilePath GetCacheFilePath(
@@ -455,11 +440,8 @@ class GDataFileSystem : public GDataFileSystemInterface,
const GetCacheStateCallback& callback) OVERRIDE;
virtual bool GetFileInfoByPath(const FilePath& gdata_file_path,
GDataFileProperties* properties) OVERRIDE;
- virtual FilePath GetGDataCacheTmpDirectory() const OVERRIDE;
- virtual FilePath GetGDataTempDownloadFolderPath() const OVERRIDE;
- virtual FilePath GetGDataTempDocumentFolderPath() const OVERRIDE;
- virtual FilePath GetGDataCachePinnedDirectory() const OVERRIDE;
- virtual FilePath GetGDataCachePersistentDirectory() const OVERRIDE;
+ virtual FilePath GetCacheDirectoryPath(
+ GDataRootDirectory::CacheSubDirectoryType sub_dir_type) const OVERRIDE;
virtual FilePath GetCacheFilePath(
const std::string& resource_id,
const std::string& md5,

Powered by Google App Engine
This is Rietveld 408576698