gdata: Get rid of GetGDataCacheTmpDirectory() and friends

chrome/browser/chromeos/gdata/gdata_files.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/gdata/gdata_files.h"
 
 #include <vector>
 
 #include "base/utf_string_conversions.h"
 #include "base/platform_file.h"
@@ skipping 20 matching lines @@
   switch (subdir) {
     case gdata::GDataRootDirectory::CACHE_TYPE_META: return "meta";
     case gdata::GDataRootDirectory::CACHE_TYPE_PINNED: return "pinned";
     case gdata::GDataRootDirectory::CACHE_TYPE_OUTGOING: return "outgoing";
     case gdata::GDataRootDirectory::CACHE_TYPE_PERSISTENT: return "persistent";
     case gdata::GDataRootDirectory::CACHE_TYPE_TMP: return "tmp";
     case gdata::GDataRootDirectory::CACHE_TYPE_TMP_DOWNLOADS:
       return "tmp_downloads";
     case gdata::GDataRootDirectory::CACHE_TYPE_TMP_DOCUMENTS:
       return "tmp_documents";
+    case gdata::GDataRootDirectory::NUM_CACHE_TYPES:
+      NOTREACHED();
   }
   NOTREACHED();
   return "unknown subdir";
 }
 
 // Extracts resource_id out of edit url.
 std::string ExtractResourceId(const GURL& url) {
   return net::UnescapeURLComponent(url.ExtractFileName(),
                                    net::UnescapeRule::URL_SPECIAL_CHARS);
 }
@@ skipping 615 matching lines @@
   bool ok = proto->ParseFromString(proto_string);
   if (ok) {
     FromProto(*proto.get());
     set_origin(FROM_CACHE);
     set_refresh_time(base::Time::Now());
   }
   return ok;
 }
 
 }  // namespace gdata