IndexedDB: chromium side of IDBCursor.advance().

content/common/indexed_db/indexed_db_messages.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Message definition file, included multiple times, hence no include guard.
 
 #include <vector>
 
 #include "content/common/indexed_db/indexed_db_key.h"
 #include "content/common/indexed_db/indexed_db_key_range.h"
@@ skipping 151 matching lines @@
 
 IPC_STRUCT_BEGIN(IndexedDBMsg_CallbacksSuccessIDBCursor_Params)
   IPC_STRUCT_MEMBER(int32, thread_id)
   IPC_STRUCT_MEMBER(int32, response_id)
   IPC_STRUCT_MEMBER(int32, cursor_id)
   IPC_STRUCT_MEMBER(IndexedDBKey, key)
   IPC_STRUCT_MEMBER(IndexedDBKey, primary_key)
   IPC_STRUCT_MEMBER(content::SerializedScriptValue, serialized_value)
 IPC_STRUCT_END()
 
+IPC_STRUCT_BEGIN(IndexedDBMsg_CallbacksSuccessCursorAdvance_Params)

[jsbell, 2012/04/24 15:41:08]

It looks like the params are identical between
CallbackSuccess{IDBCursor|CursorAdvance|CursorContinue} - while I would keep
them separate for consistency for this patch, is there any reason they couldn't
be merged in the future?

[alecflett, 2012/04/24 16:34:22]

Its very possible - this was one of the areas that confused me a bit - exactly
how these IPC messages are filled in...

+  IPC_STRUCT_MEMBER(int32, thread_id)
+  IPC_STRUCT_MEMBER(int32, response_id)
+  IPC_STRUCT_MEMBER(int32, cursor_id)
+  IPC_STRUCT_MEMBER(IndexedDBKey, key)
+  IPC_STRUCT_MEMBER(IndexedDBKey, primary_key)
+  IPC_STRUCT_MEMBER(content::SerializedScriptValue, serialized_value)
+IPC_STRUCT_END()
+
 IPC_STRUCT_BEGIN(IndexedDBMsg_CallbacksSuccessCursorContinue_Params)
   IPC_STRUCT_MEMBER(int32, thread_id)
   IPC_STRUCT_MEMBER(int32, response_id)
   IPC_STRUCT_MEMBER(int32, cursor_id)
   IPC_STRUCT_MEMBER(IndexedDBKey, key)
   IPC_STRUCT_MEMBER(IndexedDBKey, primary_key)
   IPC_STRUCT_MEMBER(content::SerializedScriptValue, serialized_value)
 IPC_STRUCT_END()
 
 IPC_STRUCT_BEGIN(IndexedDBMsg_CallbacksSuccessCursorPrefetch_Params)
@@ skipping 28 matching lines @@
 // Indexed DB messages sent from the browser to the renderer.
 
 // The thread_id needs to be the first parameter in these messages.  In the IO
 // thread on the renderer/client process, an IDB message filter assumes the
 // thread_id is the first int.
 
 // IDBCallback message handlers.
 IPC_MESSAGE_CONTROL1(IndexedDBMsg_CallbacksSuccessIDBCursor,
                      IndexedDBMsg_CallbacksSuccessIDBCursor_Params)
 
+IPC_MESSAGE_CONTROL1(IndexedDBMsg_CallbacksSuccessCursorAdvance,
+                     IndexedDBMsg_CallbacksSuccessCursorAdvance_Params)
+
 IPC_MESSAGE_CONTROL1(IndexedDBMsg_CallbacksSuccessCursorContinue,
                      IndexedDBMsg_CallbacksSuccessCursorContinue_Params)
 
 IPC_MESSAGE_CONTROL1(IndexedDBMsg_CallbacksSuccessCursorPrefetch,
                      IndexedDBMsg_CallbacksSuccessCursorPrefetch_Params)
 
 IPC_MESSAGE_CONTROL3(IndexedDBMsg_CallbacksSuccessIDBDatabase,
                      int32 /* thread_id */,
                      int32 /* response_id */,
                      int32 /* idb_database_id */)
@@ skipping 43 matching lines @@
                             int32 /* direction */)
 
 // WebIDBCursor::update() message.
 IPC_SYNC_MESSAGE_CONTROL4_1(IndexedDBHostMsg_CursorUpdate,
                      int32, /* idb_cursor_id */
                      int32, /* thread_id */
                      int32, /* response_id */
                      content::SerializedScriptValue, /* value */
                      WebKit::WebExceptionCode /* ec */)
 
+// WebIDBCursor::advance() message.
+IPC_SYNC_MESSAGE_CONTROL4_1(IndexedDBHostMsg_CursorAdvance,
+                     int32, /* idb_cursor_id */
+                     int32, /* thread_id */
+                     int32, /* response_id */
+                     unsigned long, /* count */
+                     WebKit::WebExceptionCode /* ec */)
+
 // WebIDBCursor::continue() message.
 IPC_SYNC_MESSAGE_CONTROL4_1(IndexedDBHostMsg_CursorContinue,
                      int32, /* idb_cursor_id */
                      int32, /* thread_id */
                      int32, /* response_id */
                      IndexedDBKey, /* key */
                      WebKit::WebExceptionCode /* ec */)
 
 // WebIDBCursor::prefetchContinue() message.
 IPC_SYNC_MESSAGE_CONTROL4_1(IndexedDBHostMsg_CursorPrefetch,
@@ skipping 262 matching lines @@
 IPC_MESSAGE_CONTROL1(IndexedDBHostMsg_TransactionAbort,
                      int32 /* idb_transaction_id */)
 
 // IDBTransaction::DidCompleteTaskEvents() message.
 IPC_MESSAGE_CONTROL1(IndexedDBHostMsg_TransactionDidCompleteTaskEvents,
                      int32 /* idb_transaction_id */)
 
 // WebIDBTransaction::~WebIDBTransaction() message.
 IPC_MESSAGE_CONTROL1(IndexedDBHostMsg_TransactionDestroyed,
                      int32 /* idb_transaction_id */)