chrome/browser/ui/webui/extensions/extensions_ui.cc - Issue 10196004: Changed ChromeURLDataManager to a ProfileKeyedService and made a Factory for it.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/extensions/extensions_ui.cc

Issue 10196004: Changed ChromeURLDataManager to a ProfileKeyedService and made a Factory for it. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Fixed style nit Created 8 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/webui/chrome_url_data_manager_factory.cc ('K') | « chrome/browser/ui/webui/extensions/extension_activity_ui.cc ('k') | chrome/browser/ui/webui/feedback_ui.cc » ('j') | chrome/browser/ui/webui/media/media_internals_ui.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/extensions/extensions_ui.cc

diff --git a/chrome/browser/ui/webui/extensions/extensions_ui.cc b/chrome/browser/ui/webui/extensions/extensions_ui.cc

index 072cecaa4c226be66cb37a75335f1156b78b8316..4463791fb24b0052d5eae719b8ec8388c6e9823a 100644

--- a/chrome/browser/ui/webui/extensions/extensions_ui.cc

+++ b/chrome/browser/ui/webui/extensions/extensions_ui.cc

@@ -5,7 +5,7 @@

#include "chrome/browser/ui/webui/extensions/extensions_ui.h"

#include "chrome/browser/profiles/profile.h"

-#include "chrome/browser/ui/webui/chrome_url_data_manager.h"

+#include "chrome/browser/ui/webui/chrome_url_data_manager_factory.h"

#include "chrome/browser/ui/webui/chrome_web_ui_data_source.h"

#include "chrome/browser/ui/webui/extensions/pack_extension_handler.h"

#include "chrome/browser/ui/webui/extensions/extension_settings_handler.h"

@@ -36,9 +36,9 @@ ChromeWebUIDataSource* CreateExtensionsHTMLSource() {

ExtensionsUI::ExtensionsUI(content::WebUI* web_ui) : WebUIController(web_ui) {

Profile* profile = Profile::FromWebUI(web_ui);

ChromeWebUIDataSource* source = CreateExtensionsHTMLSource();

- profile->GetChromeURLDataManager()->AddDataSource(source);

- profile->GetChromeURLDataManager()->AddDataSource(

- new SharedResourcesDataSource());

+ ChromeURLDataManagerFactory::GetForProfile(profile)->AddDataSource(source);

+ ChromeURLDataManagerFactory::GetForProfile(profile)->

+ AddDataSource(new SharedResourcesDataSource());

ExtensionSettingsHandler* handler = new ExtensionSettingsHandler();

handler->GetLocalizedValues(source->localized_strings());