chrome/browser/ui/webui/devtools_ui.cc - Issue 10196004: Changed ChromeURLDataManager to a ProfileKeyedService and made a Factory for it.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/devtools_ui.cc

Issue 10196004: Changed ChromeURLDataManager to a ProfileKeyedService and made a Factory for it. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Added static ChromeURLDataManager::AddSource() Created 8 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/profiles/off_the_record_profile_impl.cc ('K') | « chrome/browser/ui/webui/crashes_ui.cc ('k') | chrome/browser/ui/webui/downloads_dom_handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/devtools_ui.cc

diff --git a/chrome/browser/ui/webui/devtools_ui.cc b/chrome/browser/ui/webui/devtools_ui.cc

index 63a37d19eb6677f7f1a3f3f4f01db18c34be8ab1..6d17b49bfd9dfc2634b49c6d5be0c74a0058b4c1 100644

--- a/chrome/browser/ui/webui/devtools_ui.cc

+++ b/chrome/browser/ui/webui/devtools_ui.cc

@@ -92,7 +92,7 @@ void DevToolsUI::RegisterDevToolsDataSource(Profile* profile) {

static bool registered = false;

if (!registered) {

DevToolsDataSource* data_source = new DevToolsDataSource();

- profile->GetChromeURLDataManager()->AddDataSource(data_source);

+ ChromeURLDataManager::AddDataSource(profile, data_source);

registered = true;

}

@@ -100,7 +100,7 @@ void DevToolsUI::RegisterDevToolsDataSource(Profile* profile) {

DevToolsUI::DevToolsUI(content::WebUI* web_ui) : WebUIController(web_ui) {

DevToolsDataSource* data_source = new DevToolsDataSource();

Profile* profile = Profile::FromWebUI(web_ui);

- profile->GetChromeURLDataManager()->AddDataSource(data_source);

+ ChromeURLDataManager::AddDataSource(profile, data_source);

}

void DevToolsUI::RenderViewCreated(