chrome/browser/ui/webui/keyboard_ui.cc - Issue 10196004: Changed ChromeURLDataManager to a ProfileKeyedService and made a Factory for it.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/keyboard_ui.cc

Issue 10196004: Changed ChromeURLDataManager to a ProfileKeyedService and made a Factory for it. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Added static convenience method to ChromeURLDataManager, fixed style issues Created 8 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/webui/chrome_url_data_manager.cc ('K') | « chrome/browser/ui/webui/inspect_ui.cc ('k') | chrome/browser/ui/webui/media/media_internals_ui.cc » ('j') | chrome/browser/ui/webui/media/media_internals_ui.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/keyboard_ui.cc

diff --git a/chrome/browser/ui/webui/keyboard_ui.cc b/chrome/browser/ui/webui/keyboard_ui.cc

index f2a77e7275abcd253114c8aea91e9293a46c2ea7..388ae37567dcd140fc79f01614831c647faa4005 100644

--- a/chrome/browser/ui/webui/keyboard_ui.cc

+++ b/chrome/browser/ui/webui/keyboard_ui.cc

@@ -9,7 +9,7 @@

#include "base/message_loop.h"

#include "base/string_piece.h"

#include "chrome/browser/profiles/profile.h"

-#include "chrome/browser/ui/webui/chrome_url_data_manager.h"

+#include "chrome/browser/ui/webui/chrome_url_data_manager_factory.h"

#include "chrome/common/url_constants.h"

#include "content/public/browser/web_contents.h"

#include "content/public/browser/web_ui.h"

@@ -24,7 +24,8 @@ KeyboardUI::KeyboardUI(content::WebUI* web_ui)

: WebUIController(web_ui) {

KeyboardHTMLSource* html_source = new KeyboardHTMLSource();

Profile* profile = Profile::FromWebUI(web_ui);

- profile->GetChromeURLDataManager()->AddDataSource(html_source);

+ ChromeURLDataManagerFactory::GetForProfile(profile)->

+ AddDataSource(html_source);

}

KeyboardUI::~KeyboardUI() {