chrome/browser/ui/webui/extensions/extension_activity_ui.cc - Issue 10196004: Changed ChromeURLDataManager to a ProfileKeyedService and made a Factory for it.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/extensions/extension_activity_ui.cc

Issue 10196004: Changed ChromeURLDataManager to a ProfileKeyedService and made a Factory for it. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Made ChromeURLDataManager's destructor virtual Created 8 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/webui/extensions/extension_activity_ui.cc

diff --git a/chrome/browser/ui/webui/extensions/extension_activity_ui.cc b/chrome/browser/ui/webui/extensions/extension_activity_ui.cc

index 1b8c5177ea3e3f4ca7974100558af3d6eadffbab..155cf4a510d5764584b54a7242519bac28ed4a77 100644

--- a/chrome/browser/ui/webui/extensions/extension_activity_ui.cc

+++ b/chrome/browser/ui/webui/extensions/extension_activity_ui.cc

@@ -7,6 +7,7 @@

#include "base/bind.h"

#include "chrome/browser/extensions/extension_service.h"

#include "chrome/browser/profiles/profile.h"

+#include "chrome/browser/ui/webui/chrome_url_data_manager.h"

#include "chrome/browser/ui/webui/chrome_web_ui_data_source.h"

#include "chrome/browser/ui/webui/extensions/extension_icon_source.h"

#include "chrome/browser/ui/webui/shared_resources_data_source.h"

@@ -43,9 +44,8 @@ ExtensionActivityUI::ExtensionActivityUI(content::WebUI* web_ui)

base::Unretained(this)));

Profile* profile = Profile::FromWebUI(web_ui);

- profile->GetChromeURLDataManager()->AddDataSource(source);

- profile->GetChromeURLDataManager()->AddDataSource(

- new SharedResourcesDataSource());

+ ChromeURLDataManager::AddDataSource(profile, source);

+ ChromeURLDataManager::AddDataSource(profile, new SharedResourcesDataSource());

}

ExtensionActivityUI::~ExtensionActivityUI() {

« no previous file with comments | « chrome/browser/ui/webui/downloads_ui.cc ('k') | chrome/browser/ui/webui/extensions/extensions_ui.cc » ('j') | no next file with comments »