Changed ChromeURLDataManager to a ProfileKeyedService and made a Factory for it.

chrome/browser/ui/webui/media/media_internals_ui.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/webui/media/media_internals_ui.h"
 
 #include "base/values.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/ui/tab_contents/tab_contents_wrapper.h"
-#include "chrome/browser/ui/webui/chrome_url_data_manager.h"
+#include "chrome/browser/ui/webui/chrome_url_data_manager_factory.h"
 #include "chrome/browser/ui/webui/chrome_web_ui_data_source.h"
 #include "chrome/browser/ui/webui/media/media_internals_handler.h"
 #include "chrome/common/jstemplate_builder.h"
 #include "chrome/common/url_constants.h"
 #include "content/public/browser/web_contents.h"
 #include "content/public/browser/web_ui.h"
 #include "grit/browser_resources.h"
 #include "ui/base/resource/resource_bundle.h"
 
 using content::WebContents;
@@ skipping 16 matching lines @@
 //
 // MediaInternalsUI
 //
 ////////////////////////////////////////////////////////////////////////////////
 
 MediaInternalsUI::MediaInternalsUI(content::WebUI* web_ui)
     : WebUIController(web_ui) {
   web_ui->AddMessageHandler(new MediaInternalsMessageHandler());
 
   Profile* profile = Profile::FromWebUI(web_ui);
-  profile->GetChromeURLDataManager()->AddDataSource(
-      CreateMediaInternalsHTMLSource());
+  ChromeURLDataManagerFactory::GetForProfile(profile)->
+      AddDataSource(CreateMediaInternalsHTMLSource());

[Evan Stade, 2012/04/24 19:02:43]

having just read through about 50 files where this exact pattern is used, I
would suggest creating a utility function in ChromeURLDataManager so you can
just do:

  ChromeURLDataManager::AddDataSource(
      profile, CreateMediaInternalsHTMLSource());

or in many cases, like this one,

  ChromeURLDataManager::AddDataSource(
      Profile::FromWebUI(web_ui), CreateMediaInternalsHTMLSource());

[Kyle Horimoto, 2012/04/24 21:09:59]

Done on this one instance. Waiting on positive review before applying it to
everything else.

 }