Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3816)

Unified Diff: chrome/browser/ui/webui/sync_setup_handler_unittest.cc

Issue 10192005: Refactor LoginUIService to not rely on WebUI. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Review feedback. Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/webui/sync_setup_handler.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/webui/sync_setup_handler_unittest.cc
diff --git a/chrome/browser/ui/webui/sync_setup_handler_unittest.cc b/chrome/browser/ui/webui/sync_setup_handler_unittest.cc
index 581cc3311cc5f0cf774b0008377f855a909f2362..c9b3aa3fa6caf6d7e8ec893f9be8c401f2c32065 100644
--- a/chrome/browser/ui/webui/sync_setup_handler_unittest.cc
+++ b/chrome/browser/ui/webui/sync_setup_handler_unittest.cc
@@ -378,7 +378,7 @@ TEST_F(SyncSetupHandlerTest, DisplayBasicLogin) {
EXPECT_CALL(*mock_pss_, HasSyncSetupCompleted())
.WillRepeatedly(Return(false));
handler_->OpenSyncSetup(false);
- EXPECT_EQ(&web_ui_,
+ EXPECT_EQ(handler_.get(),
LoginUIServiceFactory::GetForProfile(
profile_.get())->current_login_ui());
ASSERT_EQ(1U, web_ui_.call_data().size());
@@ -406,7 +406,7 @@ TEST_F(SyncSetupHandlerTest, DisplayForceLogin) {
// This should display the login UI even though sync setup has already
// completed.
handler_->OpenSyncSetup(true);
- EXPECT_EQ(&web_ui_,
+ EXPECT_EQ(handler_.get(),
LoginUIServiceFactory::GetForProfile(
profile_.get())->current_login_ui());
ASSERT_EQ(1U, web_ui_.call_data().size());
@@ -803,7 +803,7 @@ TEST_F(SyncSetupHandlerTest, ShowSyncSetupWithAuthError) {
// This should display the login dialog (not login).
handler_->OpenSyncSetup(false);
- EXPECT_EQ(&web_ui_,
+ EXPECT_EQ(handler_.get(),
LoginUIServiceFactory::GetForProfile(
profile_.get())->current_login_ui());
ASSERT_EQ(1U, web_ui_.call_data().size());
@@ -897,7 +897,7 @@ TEST_F(SyncSetupHandlerTest, ShowSetupSyncForAllTypesIndividually) {
ExpectConfig();
// Close the config overlay.
LoginUIServiceFactory::GetForProfile(profile_.get())->LoginUIClosed(
- &web_ui_);
+ handler_.get());
const TestWebUI::CallData& data = web_ui_.call_data()[0];
DictionaryValue* dictionary;
ASSERT_TRUE(data.arg2->GetAsDictionary(&dictionary));
« no previous file with comments | « chrome/browser/ui/webui/sync_setup_handler.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698