chrome/browser/ui/webui/sync_promo/sync_promo_handler.cc - Issue 10192005: Refactor LoginUIService to not rely on WebUI.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/sync_promo/sync_promo_handler.cc

Issue 10192005: Refactor LoginUIService to not rely on WebUI. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Review feedback. Created 8 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/webui/sync_promo/sync_promo_handler.cc

diff --git a/chrome/browser/ui/webui/sync_promo/sync_promo_handler.cc b/chrome/browser/ui/webui/sync_promo/sync_promo_handler.cc

index 8e5200f6ecb1122b512e853f53ef9067f4d13c7a..c4bd0dd9080a14f966e346ce1499fa8eaed48a85 100644

--- a/chrome/browser/ui/webui/sync_promo/sync_promo_handler.cc

+++ b/chrome/browser/ui/webui/sync_promo/sync_promo_handler.cc

@@ -275,3 +275,9 @@ void SyncPromoHandler::RecordUserFlowAction(int action) {

UMA_HISTOGRAM_ENUMERATION("SyncPromo.UserFlow", action,

SYNC_PROMO_BUCKET_BOUNDARY);

}

+void SyncPromoHandler::CloseUI() {

+ // Callers should not ever try to close the promo UI (should only call

+ // CloseUI() if the user is already logged in).

+ NOTREACHED() << "Cannot close the promo UI";