Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(591)

Unified Diff: chrome/browser/sync/sync_global_error_unittest.cc

Issue 10192005: Refactor LoginUIService to not rely on WebUI. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Review feedback. Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/sync/sync_global_error.cc ('k') | chrome/browser/ui/browser.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/sync/sync_global_error_unittest.cc
diff --git a/chrome/browser/sync/sync_global_error_unittest.cc b/chrome/browser/sync/sync_global_error_unittest.cc
index 68f6cc4c5066d69171d78d59eb0095f0f641a184..87c7c4db2c4e9330ad5d36aedd982dbef70a04c2 100644
--- a/chrome/browser/sync/sync_global_error_unittest.cc
+++ b/chrome/browser/sync/sync_global_error_unittest.cc
@@ -39,7 +39,7 @@ class BrowserMock: public Browser {
class LoginUIServiceMock: public LoginUIService {
public:
explicit LoginUIServiceMock(Profile* profile) : LoginUIService(profile) {}
- MOCK_METHOD1(ShowLoginUI, void(bool));
+ MOCK_METHOD0(ShowLoginUI, void());
};
ProfileKeyedService* BuildMockLoginUIService(Profile* profile) {
@@ -110,9 +110,9 @@ void VerifySyncGlobalErrorResult(NiceMock<ProfileSyncServiceMock>* service,
#else
// Test message handler.
if (is_error) {
- EXPECT_CALL(*login_ui_service, ShowLoginUI(false));
+ EXPECT_CALL(*login_ui_service, ShowLoginUI());
error->ExecuteMenuItem(browser);
- EXPECT_CALL(*login_ui_service, ShowLoginUI(false));
+ EXPECT_CALL(*login_ui_service, ShowLoginUI());
error->BubbleViewAcceptButtonPressed(browser);
error->BubbleViewDidClose(browser);
}
« no previous file with comments | « chrome/browser/sync/sync_global_error.cc ('k') | chrome/browser/ui/browser.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698