Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Issue 10192003: NaCl: Remove forward declaration of SelLdrLauncher as a struct (Closed)

Created:
8 years, 8 months ago by Mark Seaborn
Modified:
8 years, 8 months ago
Reviewers:
bbudge
CC:
chromium-reviews
Visibility:
Public.

Description

NaCl: Remove forward declaration of SelLdrLauncher as a struct This declaration prevents us from defining SelLdrLauncher via a typedef. Plus it should really be a class, not a struct. BUG=none TEST=build Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=134196

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M ppapi/native_client/src/trusted/plugin/service_runtime.h View 2 chunks +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Mark Seaborn
I think I'll need this. If not, it's still useful to have as a cleanup. ...
8 years, 8 months ago (2012-04-26 23:07:11 UTC) #1
bbudge
lgtm
8 years, 8 months ago (2012-04-26 23:16:05 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mseaborn@chromium.org/10192003/1
8 years, 8 months ago (2012-04-26 23:16:59 UTC) #3
commit-bot: I haz the power
8 years, 8 months ago (2012-04-27 00:56:22 UTC) #4
Change committed as 134196

Powered by Google App Engine
This is Rietveld 408576698