Issue 10192001: ash: Fix transparency glitches in window header

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10192001: ash: Fix transparency glitches in window header (Closed)

Created:
8 years, 8 months ago by James Cook

Modified:
8 years, 8 months ago

Reviewers:
sky

CC:
chromium-reviews, sadrul, ben+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

ash: Fix transparency glitches in window header Due to a race between when window show/hide animations change IsVisible() and "solo" window counting for determining header transparency, a missed update when windows are hidden, and FramePainter::PaintHeader() being called repeatedly with different clip rects for widget updates, we could get into a state where the window header has different transparency values behind various views::View widgets. Fix this by using Window::TargetVisibility() instead of IsVisible() and monitoring for window visibility change events. BUG=123866 TEST=manual, see bug Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=133595