Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Issue 10191019: [cros] Fix udevadm command line for camera presence detection. (Closed)

Created:
8 years, 8 months ago by Ivan Korotkov
Modified:
8 years, 7 months ago
CC:
chromium-reviews, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

[cros] Fix udevadm command line for camera presence detection. Also added an overload of GetAppOutput which takes argv directly instead of CommandLine for launching programs where specific order of argument matters (like udevadm). BUG=124845 TEST=Manual Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=134149

Patch Set 1 #

Patch Set 2 : Add argv version of GetAppOutput. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -18 lines) Patch
M base/process_util.h View 1 1 chunk +6 lines, -0 lines 0 comments Download
M base/process_util_posix.cc View 1 6 chunks +17 lines, -14 lines 0 comments Download
M chrome/browser/chromeos/login/camera_detector.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/system/name_value_pairs_parser.cc View 1 1 chunk +5 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/system/udev_info_provider.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (0 generated)
Ivan Korotkov
8 years, 8 months ago (2012-04-25 14:14:13 UTC) #1
Nikita (slow)
lgtm
8 years, 8 months ago (2012-04-25 14:30:50 UTC) #2
Ivan Korotkov
Adding base/ OWNERS
8 years, 8 months ago (2012-04-25 14:38:09 UTC) #3
willchan no longer on Chromium
lgtm
8 years, 8 months ago (2012-04-25 21:34:51 UTC) #4
willchan no longer on Chromium
Actually, I take that back :P Why is the base/ change necessary? I just want ...
8 years, 8 months ago (2012-04-25 21:36:09 UTC) #5
Ivan Korotkov
udevadm requires arguments to be in a specific order ('info' first) which CommandLine doesn't allow ...
8 years, 8 months ago (2012-04-26 07:50:59 UTC) #6
willchan no longer on Chromium
Please update the CL description with this explanation and then LGTM. On Apr 26, 2012 ...
8 years, 7 months ago (2012-04-26 15:49:32 UTC) #7
willchan no longer on Chromium
Please update the CL description with this explanation and then LGTM. On Apr 26, 2012 ...
8 years, 7 months ago (2012-04-26 15:56:45 UTC) #8
Ivan Korotkov
Done
8 years, 7 months ago (2012-04-26 18:56:04 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ivankr@chromium.org/10191019/6001
8 years, 7 months ago (2012-04-26 18:56:18 UTC) #10
commit-bot: I haz the power
8 years, 7 months ago (2012-04-26 20:24:38 UTC) #11
Change committed as 134149

Powered by Google App Engine
This is Rietveld 408576698