Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(472)

Unified Diff: ui/views/controls/webview/webview.h

Issue 10191010: Re-implement the screensaver to use WebView instead of ExtensionDialogHost. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: . Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/views/controls/webview/webview.h
diff --git a/ui/views/controls/webview/webview.h b/ui/views/controls/webview/webview.h
index 5a73dc967f1677fb904ec300f24f9d8604c3a3f6..7bb707c7b17d41cb357219c00105ac66c551753b 100644
--- a/ui/views/controls/webview/webview.h
+++ b/ui/views/controls/webview/webview.h
@@ -73,6 +73,13 @@ class VIEWS_EXPORT WebView : public View,
// Overridden from View:
virtual std::string GetClassName() const OVERRIDE;
+ protected:
+ // Added so it can be overriden by a Test/Mock class, allowing us
+ // to create a TestWebContents instead when running unit tests.
+ virtual content::WebContents* CreateWebContents(
Ben Goodger (Google) 2012/05/01 16:57:42 So, I'm generally pretty leery of subclassing of c
rkc 2012/05/02 00:51:03 Done.
rkc 2012/05/02 00:51:03 Done.
+ content::BrowserContext* browser_context,
+ content::SiteInstance* site_instance);
+
private:
// Overridden from View:
virtual void OnBoundsChanged(const gfx::Rect& previous_bounds) OVERRIDE;
@@ -114,4 +121,4 @@ class VIEWS_EXPORT WebView : public View,
} // namespace views
-#endif // UI_VIEWS_CONTROLS_WEBVIEW_WEBVIEW_H_
+#endif // UI_VIEWS_CONTROLS_WEBVIEW_WEBVIEW_H_

Powered by Google App Engine
This is Rietveld 408576698