Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Unified Diff: chrome/browser/chromeos/kiosk_mode/kiosk_mode_screensaver.cc

Issue 10191010: Re-implement the screensaver to use WebView instead of ExtensionDialogHost. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: . Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/kiosk_mode/kiosk_mode_screensaver.cc
diff --git a/chrome/browser/chromeos/kiosk_mode/kiosk_mode_screensaver.cc b/chrome/browser/chromeos/kiosk_mode/kiosk_mode_screensaver.cc
index 9bdfb334418e32d496b141ff3f85fdbfc7461762..5680c68d5a1f472ed96fef387a7d599ae0a8d5f4 100644
--- a/chrome/browser/chromeos/kiosk_mode/kiosk_mode_screensaver.cc
+++ b/chrome/browser/chromeos/kiosk_mode/kiosk_mode_screensaver.cc
@@ -4,6 +4,7 @@
#include "chrome/browser/chromeos/kiosk_mode/kiosk_mode_screensaver.h"
+#include "ash/screensaver/screensaver_view.h"
#include "base/bind.h"
#include "base/callback.h"
#include "base/lazy_instance.h"
@@ -11,7 +12,7 @@
#include "chrome/browser/chromeos/kiosk_mode/kiosk_mode_settings.h"
#include "chrome/browser/chromeos/login/existing_user_controller.h"
#include "chrome/browser/chromeos/login/user_manager.h"
-#include "chrome/browser/chromeos/ui/screensaver_extension_dialog.h"
+#include "chrome/browser/extensions/extension_service.h"
#include "chrome/browser/extensions/sandboxed_extension_unpacker.h"
#include "chrome/common/chrome_notification_types.h"
#include "chrome/common/extensions/extension.h"
@@ -173,7 +174,14 @@ void KioskModeScreensaver::SetupScreensaver(
chromeos::DBusThreadManager::Get()->
GetPowerManagerClient()->RequestActiveNotification();
- browser::ShowScreensaverDialog(extension);
+ // Add the extension to the extension service and display the screensaver.
+ Profile* default_profile = ProfileManager::GetDefaultProfile();
+ if (!default_profile->GetExtensionService()->AddExtension(extension)) {
+ LOG(ERROR) << "Couldn't add screensaver extension to profile.";
+ return;
+ }
+
+ ash::ShowScreensaver(extension->GetFullLaunchURL());
}
// NotificationObserver overrides:
@@ -188,7 +196,7 @@ void KioskModeScreensaver::Observe(
if (power_manager->HasObserver(this))
power_manager->RemoveObserver(this);
- browser::CloseScreensaverDialog();
+ ash::CloseScreensaver();
ShutdownKioskModeScreensaver();
}
@@ -203,7 +211,7 @@ void KioskModeScreensaver::ActiveNotify() {
} else {
// Remove the screensaver so the user can at least use the underlying
// login screen to be able to log in.
- browser::CloseScreensaverDialog();
+ ash::CloseScreensaver();
}
}

Powered by Google App Engine
This is Rietveld 408576698