Re-implement the screensaver to use WebView instead of ExtensionDialogHost.

ui/views/controls/webview/webview.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef UI_VIEWS_CONTROLS_WEBVIEW_WEBVIEW_H_
 #define UI_VIEWS_CONTROLS_WEBVIEW_WEBVIEW_H_
 #pragma once
 
 #include "base/memory/scoped_ptr.h"
 #include "content/public/browser/notification_observer.h"
@@ skipping 55 matching lines @@
 
   // When used to host UI, we need to explicitly allow accelerators to be
   // processed. Default is false.
   void set_allow_accelerators(bool allow_accelerators) {
     allow_accelerators_ = allow_accelerators;
   }
 
   // Overridden from View:
   virtual std::string GetClassName() const OVERRIDE;
 
+ protected:
+  // Added so it can be overriden by a Test/Mock class, allowing us
+  // to create a TestWebContents instead when running unit tests.
+  virtual content::WebContents* CreateWebContents(

[Ben Goodger (Google), 2012/05/01 16:57:42]

So, I'm generally pretty leery of subclassing of concrete base classes like
this. I think it's overused in Chrome.

How about this for an alternate. Add a method to src/ui/views/views_delegate.h
that returns true if the app is running in a unit test, and then have the
WebView implicitly construct a test webcontents in that case.

[rkc, 2012/05/02 00:51:03]

Done.

[rkc, 2012/05/02 00:51:03]

Done.

+      content::BrowserContext* browser_context,
+      content::SiteInstance* site_instance);
+
  private:
   // Overridden from View:
   virtual void OnBoundsChanged(const gfx::Rect& previous_bounds) OVERRIDE;
   virtual void ViewHierarchyChanged(bool is_add,
                                     View* parent,
                                     View* child) OVERRIDE;
   virtual bool SkipDefaultKeyEventProcessing(
       const views::KeyEvent& event) OVERRIDE;
   virtual bool IsFocusable() const OVERRIDE;
   virtual void OnFocus() OVERRIDE;
@@ skipping 21 matching lines @@
   content::WebContents* web_contents_;
   content::BrowserContext* browser_context_;
   content::NotificationRegistrar registrar_;
   bool allow_accelerators_;
 
   DISALLOW_COPY_AND_ASSIGN(WebView);
 };
 
 }  // namespace views
 
-#endif  // UI_VIEWS_CONTROLS_WEBVIEW_WEBVIEW_H_
+#endif  // UI_VIEWS_CONTROLS_WEBVIEW_WEBVIEW_H_