Issue 10189001: Fix RenderTextWin font linking with custom fonts.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10189001: Fix RenderTextWin font linking with custom fonts. (Closed)

Created:
8 years, 8 months ago by Alexei Svitkine (slow)

Modified:
8 years, 8 months ago

Reviewers:
msw

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Fix RenderTextWin font linking with custom fonts. Call ScriptGetFontProperties() lazily, only right before its output is needed. This makes sure that the correct font's properties are used to determine if there are missing glyphs when going through the fallback / linking path. BUG=124453, 105550 TEST=See http://crbug.com/124453. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=133505

Patch Set 1 #

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -5 lines)			Patch
	M	ui/gfx/render_text_win.cc	View		2 chunks	+5 lines, -5 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/asvitkine@chromium.org/10189001/1

8 years, 8 months ago (2012-04-23 18:22:09 UTC) #3

Change committed as 133505

Expand Messages | Collapse Messages