Issue 10188005: testserver: pass options through bytes() before using with binary data.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10188005: testserver: pass options through bytes() before using with binary data. (Closed)

Created:
8 years, 8 months ago by agl

Modified:
8 years, 8 months ago

Reviewers:
Johnny(Jianning) Ding

CC:
chromium-reviews, Ryan Sleevi

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

testserver: pass options through bytes() before using with binary data. Previously the arguments to GenerateCertKeyAndOCSP were used in operations with binary data directly. If they were unicode objects then their encoding may not have supported the DER data causing an error. By passing through bytes(), we get a str object and we make it clear that we'll be using this with binary data. BUG=119642 TEST=net_unittests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=133704