Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(350)

Issue 10187021: Add key modifier to minimize/restore button click to minimize/restore-all panels for Windows. (Closed)

Created:
8 years, 8 months ago by jennb
Modified:
8 years, 8 months ago
Reviewers:
jianli
CC:
chromium-reviews, jennb, jianli, Dmitry Titov, dcheng, Andrei
Visibility:
Public.

Description

Add key modifier to minimize/restore button click to minimize/restore-all panels for Windows. Changed to use the same technique to detect key modifier for titlebar click. BUG=123176 TEST=Existing Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=134425

Patch Set 1 #

Total comments: 2

Patch Set 2 : Pass modifier instead of event around. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -57 lines) Patch
M chrome/browser/ui/panels/panel_browser_frame_view.cc View 1 2 chunks +11 lines, -6 lines 0 comments Download
M chrome/browser/ui/panels/panel_browser_view.h View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/panels/panel_browser_view.cc View 1 5 chunks +4 lines, -49 lines 0 comments Download
M chrome/browser/ui/panels/panel_browser_view_browsertest.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
jennb
8 years, 8 months ago (2012-04-27 21:56:01 UTC) #1
jianli
http://codereview.chromium.org/10187021/diff/1/chrome/browser/ui/panels/panel_browser_view.cc File chrome/browser/ui/panels/panel_browser_view.cc (right): http://codereview.chromium.org/10187021/diff/1/chrome/browser/ui/panels/panel_browser_view.cc#newcode444 chrome/browser/ui/panels/panel_browser_view.cc:444: views::View::ConvertPointToScreen(this, &mouse_location); |event| is for PanelBrowserFrameView, not PanelBrowserView. Thus ...
8 years, 8 months ago (2012-04-27 22:32:10 UTC) #2
jennb
http://codereview.chromium.org/10187021/diff/1/chrome/browser/ui/panels/panel_browser_view.cc File chrome/browser/ui/panels/panel_browser_view.cc (right): http://codereview.chromium.org/10187021/diff/1/chrome/browser/ui/panels/panel_browser_view.cc#newcode444 chrome/browser/ui/panels/panel_browser_view.cc:444: views::View::ConvertPointToScreen(this, &mouse_location); On 2012/04/27 22:32:10, jianli wrote: > |event| ...
8 years, 8 months ago (2012-04-27 23:27:54 UTC) #3
jianli
lgtm
8 years, 8 months ago (2012-04-28 00:06:33 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jennb@chromium.org/10187021/2002
8 years, 8 months ago (2012-04-28 00:11:47 UTC) #5
commit-bot: I haz the power
8 years, 8 months ago (2012-04-28 02:16:38 UTC) #6
Change committed as 134425

Powered by Google App Engine
This is Rietveld 408576698