Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4871)

Unified Diff: chrome/browser/resources/sync_setup_overlay.js

Issue 10187008: Sync UI: Ensure the close button is shown. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Review fix. Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/resources/sync_setup_overlay.html ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/sync_setup_overlay.js
diff --git a/chrome/browser/resources/sync_setup_overlay.js b/chrome/browser/resources/sync_setup_overlay.js
index a066249bb56338be5710a12a5dccfe0ab76ef866..2757000c5e527be382725a9f9539c0d0b16d3f9c 100644
--- a/chrome/browser/resources/sync_setup_overlay.js
+++ b/chrome/browser/resources/sync_setup_overlay.js
@@ -508,10 +508,12 @@ cr.define('options', function() {
showSyncSetupPage_: function(page, args) {
this.setThrobbersVisible_(false);
- // Hide an existing visible overlay.
- var overlay = $('sync-setup-overlay');
- for (var i = 0; i < overlay.children.length; i++)
- overlay.children[i].hidden = true;
+ // Hide an existing visible overlay (ensuring the close button is not
+ // hidden).
+ var children = document.querySelectorAll(
+ '#sync-setup-overlay > *:not(.close-button)');
+ for (var i = 0; i < children.length; i++)
+ children[i].hidden = true;
this.setInputElementsDisabledState_(false);
« no previous file with comments | « chrome/browser/resources/sync_setup_overlay.html ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698