Update run_test_from_archive.py to handle 404

Update run_test_from_archive.py to handle 404

Update run_test_from_archieve.py to check if a url is valid before downloading it to prevent grabbing files that are just 404s.


BUG=
TEST=


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=133709

[csharp, 2012-04-23 20:07:40]

I've spent a little too much time hunting errors only to realize that the files
downloaded where invalid.

This seemed to be the best way to add a check to ensure we only download valid
files.

Also, the presubmit check for this show failed tests (16 for
isolate_smoke_test.py) in isolate, which I could repo on a fresh checkout. Could
you take a look? Looks like the modes of files are getting correctly set.

[Marc-Antoine Ruel (Google), 2012-04-23 23:50:13]

https://chromiumcodereview.appspot.com/10187007/diff/1/tools/isolate/run_test...
File tools/isolate/run_test_from_archive.py (right):

https://chromiumcodereview.appspot.com/10187007/diff/1/tools/isolate/run_test...
tools/isolate/run_test_from_archive.py:120: remote_file =
urllib.urlopen(file_or_url)
I'd prefer to keep using urlretrieve(). Albeit it's a bit clunky to do;
http://stackoverflow.com/questions/1308542/how-to-catch-404-error-in-urllib-u...

The main issue I have is about keeping the whole data in memory, some files may
be over 1gb in size so buffering it all and then writing it may not be the most
efficient thing.

[csharp, 2012-04-24 15:18:47]

https://chromiumcodereview.appspot.com/10187007/diff/5001/tools/isolate/run_t...
File tools/isolate/run_test_from_archive.py (right):

https://chromiumcodereview.appspot.com/10187007/diff/5001/tools/isolate/run_t...
tools/isolate/run_test_from_archive.py:121:
urllib.URLopener().retrieve(file_or_url, dest)
I don't see any need to create a new subclass since throwing an exception seems
fine to me.

[M-A Ruel, 2012-04-24 15:20:41]

lgtm

[commit-bot: I haz the power, 2012-04-24 15:22:49]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/csharp@chromium.org/10187007/5001

[commit-bot: I haz the power, 2012-04-24 17:00:53]

Change committed as 133709