Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 10186011: Sync UI: Fix up the HTML by moving divs outside of the label. (Closed)

Created:
8 years, 8 months ago by James Hawkins
Modified:
8 years, 8 months ago
Reviewers:
Dan Beam
CC:
chromium-reviews, arv (Not doing code reviews)
Visibility:
Public.

Description

Sync UI: Fix up the HTML by moving divs outside of the label. Also fix style issues while I'm here. BUG=none TEST=none R=dbeam Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=133599

Patch Set 1 #

Total comments: 2

Patch Set 2 : Review fix. #

Patch Set 3 : Remove include. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -33 lines) Patch
M chrome/browser/resources/sync_setup_overlay.css View 3 chunks +8 lines, -2 lines 0 comments Download
M chrome/browser/resources/sync_setup_overlay.html View 2 chunks +15 lines, -14 lines 0 comments Download
M chrome/browser/resources/sync_setup_overlay.js View 2 8 chunks +12 lines, -11 lines 0 comments Download
M chrome/browser/ui/webui/sync_setup_handler.cc View 1 chunk +12 lines, -6 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
James Hawkins
8 years, 8 months ago (2012-04-23 20:19:45 UTC) #1
Dan Beam
http://codereview.chromium.org/10186011/diff/1/chrome/browser/resources/sync_setup_overlay.js File chrome/browser/resources/sync_setup_overlay.js (right): http://codereview.chromium.org/10186011/diff/1/chrome/browser/resources/sync_setup_overlay.js#newcode290 chrome/browser/resources/sync_setup_overlay.js:290: var datatypeSelect = $('sync-select-datatypes'); where is util.js (the file ...
8 years, 8 months ago (2012-04-23 21:25:10 UTC) #2
James Hawkins
http://codereview.chromium.org/10186011/diff/1/chrome/browser/resources/sync_setup_overlay.js File chrome/browser/resources/sync_setup_overlay.js (right): http://codereview.chromium.org/10186011/diff/1/chrome/browser/resources/sync_setup_overlay.js#newcode290 chrome/browser/resources/sync_setup_overlay.js:290: var datatypeSelect = $('sync-select-datatypes'); On 2012/04/23 21:25:10, Dan Beam ...
8 years, 8 months ago (2012-04-23 21:32:04 UTC) #3
James Hawkins
peetal
8 years, 8 months ago (2012-04-23 22:58:51 UTC) #4
Dan Beam
lgtm w/offline debug sess
8 years, 8 months ago (2012-04-23 22:59:49 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jhawkins@chromium.org/10186011/8001
8 years, 8 months ago (2012-04-24 00:12:21 UTC) #6
commit-bot: I haz the power
8 years, 8 months ago (2012-04-24 02:00:10 UTC) #7
Change committed as 133599

Powered by Google App Engine
This is Rietveld 408576698