Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2143)

Unified Diff: chrome/browser/intents/web_intents_registry_factory.cc

Issue 10185008: Taking over issue 10006037: Moved WebDataService to ProfileKeyedService (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/intents/web_intents_registry_factory.cc
===================================================================
--- chrome/browser/intents/web_intents_registry_factory.cc (revision 136877)
+++ chrome/browser/intents/web_intents_registry_factory.cc (working copy)
@@ -9,6 +9,7 @@
#include "chrome/browser/intents/web_intents_registry.h"
#include "chrome/browser/profiles/profile.h"
#include "chrome/browser/profiles/profile_dependency_manager.h"
+#include "chrome/browser/webdata/web_data_service_factory.h"
// static
WebIntentsRegistry* WebIntentsRegistryFactory::GetForProfile(Profile* profile) {
@@ -19,8 +20,7 @@
WebIntentsRegistryFactory::WebIntentsRegistryFactory()
: ProfileKeyedServiceFactory("WebIntentsRegistry",
ProfileDependencyManager::GetInstance()) {
- // TODO(erg): For Shutdown() order, we need to:
- // DependsOn(WebDataServiceFactory::GetInstance());
+ DependsOn(WebDataServiceFactory::GetInstance());
DependsOn(ExtensionSystemFactory::GetInstance());
}
@@ -35,7 +35,8 @@
ProfileKeyedService* WebIntentsRegistryFactory::BuildServiceInstanceFor(
Profile* profile) const {
WebIntentsRegistry* registry = new WebIntentsRegistry;
- registry->Initialize(profile->GetWebDataService(Profile::EXPLICIT_ACCESS),
+ registry->Initialize(WebDataServiceFactory::GetForProfile(
+ profile, Profile::EXPLICIT_ACCESS),
profile->GetExtensionService());
return registry;
}

Powered by Google App Engine
This is Rietveld 408576698