[net] Change order of RequestPriority to natural: higher > lower

net/spdy/spdy_io_buffer.h

Index: net/spdy/spdy_io_buffer.h
diff --git a/net/spdy/spdy_io_buffer.h b/net/spdy/spdy_io_buffer.h
index e96c946df4788a9087336d34c304a05156c75c4a..1b69933f323b014b95a3ce4df75542b37340f0f4 100644
--- a/net/spdy/spdy_io_buffer.h
+++ b/net/spdy/spdy_io_buffer.h
@@ -22,8 +22,7 @@ class NET_EXPORT_PRIVATE SpdyIOBuffer {
   // Constructor
   // |buffer| is the actual data buffer.
   // |size| is the size of the data buffer.
-  // |priority| is the priority of this buffer.  Lower numbers are higher
-  //            priority.
+  // |priority| is the priority of this buffer.
   // |stream| is a pointer to the stream which is managing this buffer.
   SpdyIOBuffer(IOBuffer* buffer, int size, int priority, SpdyStream* stream);

[Ryan Hamilton, 2012/04/23 22:51:05]

Can you make |priority| a RequestPriority?  It looks like
SpdySession::QueueFrame is construction SpdyIOBuffers with RequestPriority so I
hope this would be an easy change.

[szym, 2012/04/24 00:19:31]

I considered that. The only doubt was caused by the unit test which creates
SpdyIOBuffer with priorities 0..100. Would using undefined enum values be ok?

[Ryan Hamilton, 2012/04/24 00:42:11]

Hm.  I think I would be inclined to change the class to use RequestPriority, and
change the test to only create NUM_PRIORITIES priorities.  I fear that having a
class with SPDY in the name that takes an int priority but whose value is not a
SPDY priority, is just asking for problems :>  (You updated the comment, which
is awesome, but I'm still afraid I'd do the wrong thing in the future).  Work
for you?

[szym, 2012/04/24 00:47:58]

Yup. I'm on it.

   SpdyIOBuffer();
@@ -39,7 +38,7 @@ class NET_EXPORT_PRIVATE SpdyIOBuffer {
   // Comparison operator to support sorting.
   bool operator<(const SpdyIOBuffer& other) const {
     if (priority_ != other.priority_)
-      return priority_ > other.priority_;
+      return priority_ < other.priority_;
     return position_ > other.position_;
   }