Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(598)

Unified Diff: net/base/prioritized_dispatcher_unittest.cc

Issue 10185007: [net] Change order of RequestPriority to natural: higher > lower (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Use MINIMUM_PRIORITY instead of 0. Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/base/prioritized_dispatcher_unittest.cc
diff --git a/net/base/prioritized_dispatcher_unittest.cc b/net/base/prioritized_dispatcher_unittest.cc
index ff32003a638d4ac2d9aa9f2d92d71ab0b9e7f2f3..cafde8230e267c1efa0890aceb894a123e93a5c1 100644
--- a/net/base/prioritized_dispatcher_unittest.cc
+++ b/net/base/prioritized_dispatcher_unittest.cc
@@ -17,10 +17,10 @@ namespace net {
namespace {
// We rely on the priority enum values being sequential having starting at 0,
-// and increasing for lower priorities.
-COMPILE_ASSERT(HIGHEST == 0u &&
- LOWEST > HIGHEST &&
- IDLE > LOWEST &&
+// and increasing for higher priorities.
+COMPILE_ASSERT(MINIMUM_PRIORITY == 0u &&
Ryan Hamilton 2012/04/23 22:51:05 Please also assert that IDLE == 0 (or == MINIMUM_P
mmenke 2012/04/24 14:30:18 nit: Suggest you switch the order of the above tw
+ LOWEST < HIGHEST &&
+ IDLE < LOWEST &&
NUM_PRIORITIES > IDLE,
priority_indexes_incompatible);

Powered by Google App Engine
This is Rietveld 408576698