[net] Change order of RequestPriority to natural: higher > lower

net/base/prioritized_dispatcher.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef NET_BASE_PRIORITY_DISPATCH_H_
 #define NET_BASE_PRIORITY_DISPATCH_H_
 #pragma once
 
 #include <vector>
 
 #include "net/base/net_export.h"
 #include "net/base/priority_queue.h"
 
 namespace net {
 
-// A priority-based dispatcher of jobs. Dispatch order is by priority (lowest
+// A priority-based dispatcher of jobs. Dispatch order is by priority (highest

[Ryan Hamilton, 2012/04/23 22:51:05]

I didn't expect to see a comment change in a consumer.  Was the old comment
incorrect, or is there a change in functionality?  (I think the former)

[szym, 2012/04/24 00:19:31]

The old comment was misleading and a source of confusion both in the original
review (eroman@) and the readability review (stevez@). The functionality is the
same. 

 // first) and then FIFO. The dispatcher enforces limits on the number of running
 // jobs. It never revokes a job once started. The job must call OnJobFinished
 // once it finishes in order to dispatch further jobs.
 //
 // All operations are O(p) time for p priority levels. The class is fully
 // reentrant: it is safe to execute any method (incl. destructor) from within
 // Job callbacks. However, this class is NOT thread-safe, which is enforced
 // by the underlying non-thread-safe PriorityQueue.
 //
 class NET_EXPORT_PRIVATE PrioritizedDispatcher {
  public:
   class Job;
   typedef PriorityQueue<Job*>::Priority Priority;
 
   // Describes the limits for the number of jobs started by the dispatcher.
   // For example, |total_jobs| = 30 and |reserved_slots| = { 5, 10, 5 }
   // allow for at most 30 running jobs in total. If there are already 24 jobs
   // running, then there can be 6 more jobs started of which at most 1 can be
-  // at priority 1 or 0, but the rest has to be at 0.
+  // at priority 1 or 2, but the rest has to be at 2.

[Ryan Hamilton, 2012/04/23 22:51:05]

nit: "the rest have to be" (instead of has)

   struct NET_EXPORT_PRIVATE Limits {
     Limits(Priority num_priorities, size_t total_jobs);
     ~Limits();
 
     // Total allowed running jobs.
     size_t total_jobs;
     // Number of slots reserved for each priority and higher.
     // Sum of |reserved_slots| must be no greater than |total_jobs|.
     std::vector<size_t> reserved_slots;
   };
@@ skipping 60 matching lines @@
   // Total number of running jobs.
   size_t num_running_jobs_;
 
   DISALLOW_COPY_AND_ASSIGN(PrioritizedDispatcher);
 };
 
 }  // namespace net
 
 #endif  // NET_BASE_PRIORITY_DISPATCH_H_