Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(334)

Issue 10184009: Add missing checks that default search contains search term replacement. (Closed)

Created:
8 years, 8 months ago by Ivan Korotkov
Modified:
8 years, 8 months ago
Reviewers:
Peter Kasting
CC:
chromium-reviews
Visibility:
Public.

Description

Add missing checks that default search contains search term replacement. BUG=116952 TEST=TemplateURLServiceTest.* Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=133510

Patch Set 1 #

Patch Set 2 : Merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M chrome/browser/search_engines/template_url_service.cc View 1 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
Ivan Korotkov
8 years, 8 months ago (2012-04-23 16:45:20 UTC) #1
Peter Kasting
LGTM. I wonder if we should add some code to the policy checker so that ...
8 years, 8 months ago (2012-04-23 18:01:17 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ivankr@chromium.org/10184009/1
8 years, 8 months ago (2012-04-23 18:47:17 UTC) #3
commit-bot: I haz the power
Can't apply patch for file chrome/browser/search_engines/template_url_service.cc. While running patch -p1 --forward --force; patching file chrome/browser/search_engines/template_url_service.cc ...
8 years, 8 months ago (2012-04-23 18:47:19 UTC) #4
Ivan Korotkov
Makes sense for the sake of transparency for sysadmins. I'm not familiar with policy-related code, ...
8 years, 8 months ago (2012-04-23 18:47:24 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ivankr@chromium.org/10184009/3
8 years, 8 months ago (2012-04-23 18:56:47 UTC) #6
Peter Kasting
On 2012/04/23 18:01:17, Peter Kasting wrote: > LGTM. I wonder if we should add some ...
8 years, 8 months ago (2012-04-23 20:13:33 UTC) #7
commit-bot: I haz the power
8 years, 8 months ago (2012-04-23 20:29:12 UTC) #8
Change committed as 133510

Powered by Google App Engine
This is Rietveld 408576698