Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4905)

Unified Diff: chrome/browser/resources/ntp4/suggestions_page.js

Issue 10182006: Adds the MostVisitedAction stat. This stat will provide a baseline to compare (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Sync'ed. Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/ntp4/suggestions_page.js
===================================================================
--- chrome/browser/resources/ntp4/suggestions_page.js (revision 134118)
+++ chrome/browser/resources/ntp4/suggestions_page.js (working copy)
@@ -8,16 +8,6 @@
var TilePage = ntp.TilePage;
/**
- * See description for these values in suggestions_page_handler.h.
- * @enum {number}
- */
- var SuggestedSitesAction = {
- CLICKED_SUGGESTED_TILE: 11,
- CLICKED_OTHER_NTP_PANE: 12,
- OTHER: 13
- };
-
- /**
* A counter for generating unique tile IDs.
*/
var tileID = 0;
@@ -145,7 +135,7 @@
chrome.send('metricsHandler:recordInHistogram',
['NewTabPage.SuggestedSite', this.index, 8]);
chrome.send('suggestedSitesAction',
- [SuggestedSitesAction.CLICKED_SUGGESTED_TILE]);
+ [NtpFollowAction.CLICKED_TILE]);
}
},
@@ -334,8 +324,10 @@
* @param {Event} e The CardChanged event.
*/
handleCardDeselected_: function(e) {
- chrome.send('suggestedSitesAction',
- [SuggestedSitesAction.CLICKED_OTHER_NTP_PANE]);
+ if (!document.documentElement.classList.contains('starting-up')) {
+ chrome.send('suggestedSitesAction',
+ [NtpFollowAction.CLICKED_OTHER_NTP_PANE]);
+ }
},
/**
@@ -344,7 +336,8 @@
* @param {Event} e The CardChanged event.
*/
handleCardSelected_: function(e) {
- chrome.send('suggestedSitesSelected');
+ if (!document.documentElement.classList.contains('starting-up'))
+ chrome.send('suggestedSitesSelected');
},
/**
@@ -379,6 +372,20 @@
};
/**
+ * Executed once the NTP has loaded. Checks if the Suggested pane is
+ * shown or not. If it is shown, the 'suggestedSitesSelected' message is sent
+ * to the C++ code, to record the fact that the user has seen this pane.
+ */
+ SuggestionsPage.onLoaded = function() {
+ if (ntp.getCardSlider() && ntp.getCardSlider().currentCardValue) {
+ if (ntp.getCardSlider().currentCardValue.classList
+ .contains('suggestions-page')) {
+ chrome.send('suggestedSitesSelected');
+ }
+ }
+ }
+
+ /**
* We've gotten additional data for Suggestions page. Update our old data with
* the new data. The ordering of the new data is not important, except when a
* page is pinned. Thus we try to minimize re-ordering.
@@ -455,3 +462,5 @@
refreshData: refreshData,
};
});
+
+document.addEventListener('ntpLoaded', ntp.SuggestionsPage.onLoaded);

Powered by Google App Engine
This is Rietveld 408576698