Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Unified Diff: src/trusted/nonnacl_util/sel_ldr_launcher_chrome.cc

Issue 10180015: Split SelLdrLauncher into SelLdrLauncher{Standalone,Chrome} classes (Closed) Base URL: svn://svn.chromium.org/native_client/trunk/src/native_client
Patch Set: Copyright Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/trusted/nonnacl_util/sel_ldr_launcher.cc ('k') | src/trusted/nonnacl_util/win/sel_ldr_launcher_win.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/trusted/nonnacl_util/sel_ldr_launcher_chrome.cc
diff --git a/src/trusted/nonnacl_util/sel_ldr_launcher_chrome.cc b/src/trusted/nonnacl_util/sel_ldr_launcher_chrome.cc
index bdb6aa7a0f7c9335d86a4bf2d9fecc06f912d006..a7d2c523418386bfd6c46e10396b5c4f0e83d850 100644
--- a/src/trusted/nonnacl_util/sel_ldr_launcher_chrome.cc
+++ b/src/trusted/nonnacl_util/sel_ldr_launcher_chrome.cc
@@ -12,9 +12,8 @@
LaunchNaClProcessFunc launch_nacl_process = NULL;
-#if !defined(NACL_STANDALONE)
namespace nacl {
-bool SelLdrLauncher::Start(const char* url) {
+bool SelLdrLauncherChrome::Start(const char* url) {
// send a synchronous message to the browser process
// TODO(mseaborn): Remove the nacl_proc_handle and nacl_proc_id
// arguments. Chromium is being changed not to give the renderer
@@ -32,7 +31,6 @@ bool SelLdrLauncher::Start(const char* url) {
return false;
}
- CloseHandlesAfterLaunch();
#if NACL_WINDOWS
if (nacl_proc_handle != kInvalidHandle &&
nacl_proc_handle != NULL) {
@@ -42,12 +40,4 @@ bool SelLdrLauncher::Start(const char* url) {
return true;
}
-bool SelLdrLauncher::Start(int socket_count,
- Handle* result_sockets,
- const char* url) {
- UNREFERENCED_PARAMETER(socket_count);
- UNREFERENCED_PARAMETER(result_sockets);
- return Start(url);
-}
} // namespace
-#endif // !defined(NACL_STANDALONE)
« no previous file with comments | « src/trusted/nonnacl_util/sel_ldr_launcher.cc ('k') | src/trusted/nonnacl_util/win/sel_ldr_launcher_win.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698