Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 10180015: Split SelLdrLauncher into SelLdrLauncher{Standalone,Chrome} classes (Closed)

Created:
8 years, 8 months ago by Mark Seaborn
Modified:
8 years, 8 months ago
CC:
native-client-reviews_googlegroups.com, bbudge
Visibility:
Public.

Description

Split SelLdrLauncher into SelLdrLauncher{Standalone,Chrome} classes This will make it easier to move sel_ldr_launcher_chrome.cc into the Chromium repo. This removes the need for the use of "#ifdef NACL_STANDALONE". This removes these unused bits: * The SelLdrLauncher constructor that takes a SelLdrLocator. * The Start() method that takes a socket_count argument. BUG=http://code.google.com/p/nativeclient/issues/detail?id=2750 TEST=trybots + build Chromium Committed: https://src.chromium.org/viewvc/native_client?view=rev&revision=8444

Patch Set 1 #

Patch Set 2 : Copyright #

Unified diffs Side-by-side diffs Delta from patch set Stats (+112 lines, -136 lines) Patch
M src/trusted/nonnacl_util/posix/sel_ldr_launcher_posix.cc View 6 chunks +6 lines, -17 lines 0 comments Download
M src/trusted/nonnacl_util/sel_ldr_launcher.h View 5 chunks +63 lines, -42 lines 0 comments Download
M src/trusted/nonnacl_util/sel_ldr_launcher.cc View 7 chunks +27 lines, -41 lines 0 comments Download
M src/trusted/nonnacl_util/sel_ldr_launcher_chrome.cc View 3 chunks +1 line, -11 lines 0 comments Download
M src/trusted/nonnacl_util/win/sel_ldr_launcher_win.cc View 5 chunks +9 lines, -20 lines 0 comments Download
M src/trusted/sel_universal/reverse_emulate.h View 1 3 chunks +4 lines, -3 lines 0 comments Download
M src/trusted/sel_universal/reverse_emulate.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/trusted/sel_universal/sel_universal.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Mark Seaborn
This depends on http://codereview.chromium.org/10192003/ being DEPS'd into NaCl.
8 years, 8 months ago (2012-04-27 00:51:36 UTC) #1
sehr (please use chromium)
8 years, 8 months ago (2012-04-27 20:33:09 UTC) #2
LGTM and nicely done!

Powered by Google App Engine
This is Rietveld 408576698