Issue 10180008: Renaming Open full screen -> Open maximized.

Issue 10180008: Renaming Open full screen -> Open maximized. (Closed)

Created:
8 years, 8 months ago by Emmanuel Saint-loubert-Bié

Modified:
8 years, 8 months ago

Reviewers:
sky

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Renaming Open full screen -> Open maximized. BUG=124642 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=133617

Patch Set 2 : Adding string. #

Patch Set 3 : 'Merged #

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -2 lines)			Patch
M	chrome/app/generated_resources.grd	View		2 chunks	+8 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/views/ash/app_list/extension_app_item.cc	View	1	1 chunk	+3 lines, -1 line	0 comments	Download
M	chrome/browser/ui/views/ash/launcher/launcher_context_menu.cc	View	1 2	1 chunk	+3 lines, -1 line	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Emmanuel Saint-loubert-Bié

Hi Scott, Please take a look. Thanks, -- Emmanuel

8 years, 8 months ago (2012-04-23 20:01:42 UTC) #1

sky

https://chromiumcodereview.appspot.com/10180008/diff/1/chrome/app/generated_resources.grd File chrome/app/generated_resources.grd (left): https://chromiumcodereview.appspot.com/10180008/diff/1/chrome/app/generated_resources.grd#oldcode9580 chrome/app/generated_resources.grd:9580: <message name="IDS_APP_CONTEXT_MENU_OPEN_FULLSCREEN" Rename the constant too.

8 years, 8 months ago (2012-04-23 20:53:51 UTC) #2

Emmanuel Saint-loubert-Bié

Hi Scott, > name="IDS_APP_CONTEXT_MENU_OPEN_FULLSCREEN" > Rename the constant too. Silly me, yes of course. Thanks ...

8 years, 8 months ago (2012-04-23 23:41:44 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/saintlou@chromium.org/10180008/17001

8 years, 8 months ago (2012-04-24 00:53:45 UTC) #5

Change committed as 133617

Expand Messages | Collapse Messages