Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 10179005: Roll Skia DEPS to 3754; add recent source files to skia.gyp. (Closed)

Created:
8 years, 8 months ago by Tom Hudson
Modified:
8 years, 8 months ago
Reviewers:
_cary, epoger
CC:
chromium-reviews, skia-dev_google.com
Visibility:
Public.

Description

Roll Skia DEPS to 3754; add recent source files to skia.gyp. Control group is at http://codereview.chromium.org/10190009/. That failed due to whitespace file conflicts. Second pass is at http://codereview.chromium.org/10186010/. win-gpu bot appears to be flaky.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download
M skia/skia.gyp View 3 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Tom Hudson
Rollin' rollin' rollin', keep that Skia rollin'.
8 years, 8 months ago (2012-04-23 19:45:35 UTC) #1
Tom Hudson
LG2Y, anybody? This run generally did better than the control (http://codereview.chromium.org/10186010/) - not that it ...
8 years, 8 months ago (2012-04-24 12:08:57 UTC) #2
epoger
LGTM
8 years, 8 months ago (2012-04-24 13:50:08 UTC) #3
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
8 years, 8 months ago (2012-04-24 13:53:04 UTC) #4
_cary
lgtm
8 years, 8 months ago (2012-04-24 14:13:32 UTC) #5
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
8 years, 8 months ago (2012-04-24 14:15:13 UTC) #6
epoger
I have landed this change as http://crrev.com/133677 You can close this CL...
8 years, 8 months ago (2012-04-24 14:30:17 UTC) #7
Tom Hudson
8 years, 8 months ago (2012-04-24 14:32:35 UTC) #8
Thanks again, Elliot!

Powered by Google App Engine
This is Rietveld 408576698