Issue 10179003: IndexedDB: remove proxy and IPC code for the IDBKey-based get/getKey.

Issue 10179003: IndexedDB: remove proxy and IPC code for the IDBKey-based get/getKey. (Closed)

Created:
8 years, 8 months ago by alecflett

Modified:
8 years, 8 months ago

Reviewers:
jsbell

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam

Base URL:
http://git.chromium.org/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

IndexedDB: remove proxy and IPC code for the IDBKey-based get/getKey. This is purely removing code that is no longer called, since https://bugs.webkit.org/show_bug.cgi?id=83638 has been fixed. BUG=124650 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=133517

Patch Set 2 : Updated formatting #

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -238 lines)			Patch
M	content/browser/in_process_webkit/indexed_db_dispatcher_host.h	View		2 chunks	+3 lines, -21 lines	0 comments	Download
M	content/browser/in_process_webkit/indexed_db_dispatcher_host.cc	View	1	5 chunks	+0 lines, -69 lines	0 comments	Download
M	content/common/indexed_db/indexed_db_dispatcher.h	View		1 chunk	+3 lines, -21 lines	0 comments	Download
M	content/common/indexed_db/indexed_db_dispatcher.cc	View		6 chunks	+3 lines, -52 lines	0 comments	Download
M	content/common/indexed_db/indexed_db_messages.h	View		3 chunks	+0 lines, -27 lines	0 comments	Download
M	content/common/indexed_db/proxy_webidbindex_impl.h	View		1 chunk	+0 lines, -8 lines	0 comments	Download
M	content/common/indexed_db/proxy_webidbindex_impl.cc	View		1 chunk	+2 lines, -24 lines	0 comments	Download
M	content/common/indexed_db/proxy_webidbobjectstore_impl.h	View		1 chunk	+0 lines, -4 lines	0 comments	Download
M	content/common/indexed_db/proxy_webidbobjectstore_impl.cc	View		1 chunk	+1 line, -12 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

alecflett

jsbell: mind a quick review to get rid of this cruft? Webkit patch comes after ...

8 years, 8 months ago (2012-04-23 18:05:59 UTC) #1

jsbell

lgtm with formatting nits https://chromiumcodereview.appspot.com/10179003/diff/1/content/browser/in_process_webkit/indexed_db_dispatcher_host.cc File content/browser/in_process_webkit/indexed_db_dispatcher_host.cc (right): https://chromiumcodereview.appspot.com/10179003/diff/1/content/browser/in_process_webkit/indexed_db_dispatcher_host.cc#newcode508 content/browser/in_process_webkit/indexed_db_dispatcher_host.cc:508: IPC_MESSAGE_HANDLER(IndexedDBHostMsg_IndexGetObject, Nit: Does this fit ...

8 years, 8 months ago (2012-04-23 18:23:59 UTC) #2

alecflett

One nit addressed - other one is a local-consistency issue https://chromiumcodereview.appspot.com/10179003/diff/1/content/browser/in_process_webkit/indexed_db_dispatcher_host.cc File content/browser/in_process_webkit/indexed_db_dispatcher_host.cc (right): https://chromiumcodereview.appspot.com/10179003/diff/1/content/browser/in_process_webkit/indexed_db_dispatcher_host.cc#newcode508 ...

8 years, 8 months ago (2012-04-23 19:18:37 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alecflett@chromium.org/10179003/4001

8 years, 8 months ago (2012-04-23 19:19:32 UTC) #4

Change committed as 133517

Expand Messages | Collapse Messages