Create an external source for extensions on linux that meets the needs of package managers.

chrome/browser/extensions/external_extension_util.cc

+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/extensions/external_extension_util.h"
+
+#include "base/bind.h"
+#include "base/file_path.h"
+#include "base/file_util.h"
+#include "base/json/json_file_value_serializer.h"
+#include "base/json/json_string_value_serializer.h"
+#include "base/string_util.h"
+#include "base/utf_string_conversions.h"
+#include "base/values.h"
+#include "base/version.h"
+
+

[Finnur, 2012/04/24 13:03:24]

nit: remove extra line.

+// Extracts/expect a file content in json format.
+// Used by the external extension facilities/providers
+//  to parse their extension manifests.

[Finnur, 2012/04/24 13:03:24]

nit: Extra space at front.

[Alexandre Abreu, 2012/04/24 19:30:30]

Done.

+// Caller takes ownership of the returned dictionary.

[Finnur, 2012/04/24 13:03:24]

This should be moved to the .h file. It is also a bit terse.
I like the fact that ownership is documented but I'm less enthusiastic about the
fact that |path| and |serializer| are not explained and that more emphasis is on
who uses the function than describing what it does. The function also has a very
generic name. Hmm.... maybe with the ExternalExtensionUtil prefix it is OK...

[Alexandre Abreu, 2012/04/24 19:30:30]

Done.

+DictionaryValue* ExternalExtensionUtil::ExtractPrefs(

[Finnur, 2012/04/24 13:03:24]

Hmm... this function is actually, in large part, doing what
DictionaryValue::GetAsDictionary is meant to do. Is there a reason why you don't
just use that function instead of largely reimplementing it here?

[Alexandre Abreu, 2012/04/24 19:30:30]

Done.

+    const FilePath& path,
+    base::ValueSerializer* serializer) {
+  std::string error_msg;
+  Value* extensions = serializer->Deserialize(NULL, &error_msg);
+  if (!extensions) {
+    LOG(WARNING) << "Unable to deserialize json data: " << error_msg
+                 << " In file " << path.value() << " .";

[Finnur, 2012/04/24 13:03:24]

nit: Extra space before period (also on line 33).

Furthermore, for readability, please put a...
  return new DictionaryValue;
... at line 30 and get rid of the else clause nesting.

Same with line 32.

[Alexandre Abreu, 2012/04/24 19:30:30]

Done.

+  } else {
+    if (!extensions->IsType(Value::TYPE_DICTIONARY)) {
+      LOG(WARNING) << "Expected a JSON dictionary in file "
+                   << path.value() << " .";
+    } else {
+      return static_cast<DictionaryValue*>(extensions);
+    }
+  }
+  return new DictionaryValue;
+}
+