Fixes possible crash in closing menus. Specifically if we Close a

Fixes possible crash in closing menus. Specifically if we Close a
menu but the parent closes before the Widget::CloseNow task is
processed then MenuHost can attempt to access a deleted menu item.

BUG=125395
TEST=none
R=ben@chromium.org


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=134422

[Ben Goodger (Google), 2012-04-27 22:56:32]

LGTM

On Fri, Apr 27, 2012 at 3:50 PM, <sky@chromium.org> wrote:

> Reviewers: Ben Goodger (Google),
>
> Description:
> Fixes possible crash in closing menus. Specifically if we Close a
> menu but the parent closes before the Widget::CloseNow task is
> processed then MenuHost can attempt to access a deleted menu item.
>
> BUG=125395
> TEST=none
> R=ben@chromium.org
>
>
> Please review this at
http://codereview.chromium.**org/10178031/<http://codereview.chromium.org/101...
>
> SVN Base:
svn://svn.chromium.org/chrome/**trunk/src<http://svn.chromium.org/chrome/trunk/src>
>
> Affected files:
>  M ui/views/controls/menu/menu_**host.cc
>
>
> Index: ui/views/controls/menu/menu_**host.cc
> diff --git a/ui/views/controls/menu/menu_**host.cc
> b/ui/views/controls/menu/menu_**host.cc
> index 44d2f62543d5557d7c9a79634de62f**9eb8039b67..**
> 4a887e56c0df83b9ff70abde1cc91f**1eb9ea1340 100644
> --- a/ui/views/controls/menu/menu_**host.cc
> +++ b/ui/views/controls/menu/menu_**host.cc
> @@ -109,6 +109,9 @@ void MenuHost::**OnNativeWidgetDestroyed() {
>  }
>
>  void MenuHost::OnOwnerClosing() {
> +  if (destroying_)
> +    return;
> +
>   MenuController* menu_controller =
>       submenu_->GetMenuItem()->**GetMenuController();
>   if (menu_controller && !menu_controller->drag_in_**progress())
>
>
>

[commit-bot: I haz the power, 2012-04-27 23:52:38]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sky@chromium.org/10178031/1

[commit-bot: I haz the power, 2012-04-28 02:12:21]

Change committed as 134422