Add net_jni_registrar.

Add net_jni_registrar.

It's used as a centralized place to register JNI hooks for Android
components in the net package.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=134396

[Ryan Sleevi, 2012-04-27 21:43:20]

So, I can rubberstamp this, but I'll be the first to admit I'm not really sure
what it's doing.

Someone with the Android background (John) should review it for Android-ness,
but everything LGTM from the net/ side.

http://codereview.chromium.org/10178023/diff/1/net/android/net_jni_registrar.cc
File net/android/net_jni_registrar.cc (right):

http://codereview.chromium.org/10178023/diff/1/net/android/net_jni_registrar....
net/android/net_jni_registrar.cc:17: { "AndroidNetworkLibrary",
net::android::RegisterNetworkLibrary},
nit: "Library}," -> "Library },"

[John Grabowski, 2012-04-27 21:47:24]

LGTM

Document this (downstream doc for upstreamers) as an example of proper
registration for other components to follow.

http://codereview.chromium.org/10178023/diff/1/net/android/net_jni_registrar.h
File net/android/net_jni_registrar.h (right):

http://codereview.chromium.org/10178023/diff/1/net/android/net_jni_registrar....
net/android/net_jni_registrar.h:6: #define NET_ANDROID_NET_JNI_REGISTRAR_H_
Apparently #pragma once is in the chromium style guide.
http://dev.chromium.org/developers/coding-style

[commit-bot: I haz the power, 2012-04-27 21:57:44]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yfriedman@chromium.org/10178023/4001

[Yaron, 2012-04-27 22:39:09]

Thanks for the reviews.

Ryan: The point of these is to setup the JNI hooks so native calls can be routed
to their native counterparts and vice-versa

http://codereview.chromium.org/10178023/diff/1/net/android/net_jni_registrar.cc
File net/android/net_jni_registrar.cc (right):

http://codereview.chromium.org/10178023/diff/1/net/android/net_jni_registrar....
net/android/net_jni_registrar.cc:17: { "AndroidNetworkLibrary",
net::android::RegisterNetworkLibrary},
On 2012/04/27 21:43:20, Ryan Sleevi wrote:
> nit: "Library}," -> "Library },"

Done.

http://codereview.chromium.org/10178023/diff/1/net/android/net_jni_registrar.h
File net/android/net_jni_registrar.h (right):

http://codereview.chromium.org/10178023/diff/1/net/android/net_jni_registrar....
net/android/net_jni_registrar.h:6: #define NET_ANDROID_NET_JNI_REGISTRAR_H_
On 2012/04/27 21:47:25, John Grabowski wrote:
> Apparently #pragma once is in the chromium style guide.
> http://dev.chromium.org/developers/coding-style

Done.

[commit-bot: I haz the power, 2012-04-27 23:41:13]

Change committed as 134396