Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 10178023: Add net_jni_registrar. (Closed)

Created:
8 years, 7 months ago by Yaron
Modified:
8 years, 7 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, cbentzel+watch_chromium.org, jam, Philippe
Visibility:
Public.

Description

Add net_jni_registrar. It's used as a centralized place to register JNI hooks for Android components in the net package. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=134396

Patch Set 1 #

Total comments: 4

Patch Set 2 : nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -1 line) Patch
M content/browser/android/library_loader_hooks.cc View 2 chunks +3 lines, -1 line 0 comments Download
A net/android/net_jni_registrar.h View 1 1 chunk +20 lines, -0 lines 0 comments Download
A net/android/net_jni_registrar.cc View 1 1 chunk +27 lines, -0 lines 0 comments Download
M net/net.gyp View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Yaron
8 years, 7 months ago (2012-04-27 21:34:13 UTC) #1
Ryan Sleevi
So, I can rubberstamp this, but I'll be the first to admit I'm not really ...
8 years, 7 months ago (2012-04-27 21:43:20 UTC) #2
John Grabowski
LGTM Document this (downstream doc for upstreamers) as an example of proper registration for other ...
8 years, 7 months ago (2012-04-27 21:47:24 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yfriedman@chromium.org/10178023/4001
8 years, 7 months ago (2012-04-27 21:57:44 UTC) #4
Yaron
Thanks for the reviews. Ryan: The point of these is to setup the JNI hooks ...
8 years, 7 months ago (2012-04-27 22:39:09 UTC) #5
commit-bot: I haz the power
8 years, 7 months ago (2012-04-27 23:41:13 UTC) #6
Change committed as 134396

Powered by Google App Engine
This is Rietveld 408576698