Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(258)

Issue 10178011: [protector,win] Fix protector.ProtectorSessionStartupTest.testSessionStartupPrefMigrationFromHomepa… (Closed)

Created:
8 years, 8 months ago by Ivan Korotkov
Modified:
8 years, 8 months ago
CC:
chromium-reviews, dennis_jeffrey, anantha, dyu1
Visibility:
Public.

Description

[protector,win] Fix protector.ProtectorSessionStartupTest.testSessionStartupPrefMigrationFromHomepage on Win. BUG=125373 TEST=protector.py NOTRY=true Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=134445

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M chrome/test/functional/protector.py View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
Ivan Korotkov
8 years, 8 months ago (2012-04-27 13:14:03 UTC) #1
Tyler Breisacher (Chromium)
As I said over email, I didn't realize that "homepage is ntp" apparently has a ...
8 years, 8 months ago (2012-04-27 18:30:08 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ivankr@chromium.org/10178011/1
8 years, 8 months ago (2012-04-27 18:53:54 UTC) #3
commit-bot: I haz the power
Try job failure for 10178011-1 (retry) on mac_rel for step "check_deps". It's a second try, ...
8 years, 8 months ago (2012-04-27 19:49:43 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ivankr@chromium.org/10178011/1
8 years, 8 months ago (2012-04-27 23:13:22 UTC) #5
commit-bot: I haz the power
Try job failure for 10178011-1 (retry) on win_rel for step "compile" (clobber build). It's a ...
8 years, 8 months ago (2012-04-27 23:51:58 UTC) #6
Tyler Breisacher (Chromium)
Assuming all the migration tests still pass locally, I would say it's safe to do ...
8 years, 8 months ago (2012-04-27 23:54:12 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ivankr@chromium.org/10178011/1
8 years, 8 months ago (2012-04-28 06:15:23 UTC) #8
commit-bot: I haz the power
Change committed as 134445
8 years, 8 months ago (2012-04-28 06:32:54 UTC) #9
Nirnimesh
On 2012/04/28 06:32:54, I haz the power (commit-bot) wrote: > Change committed as 134445 I ...
8 years, 8 months ago (2012-04-28 06:37:36 UTC) #10
Ivan Korotkov
8 years, 8 months ago (2012-04-28 07:31:09 UTC) #11
Thanks!

Powered by Google App Engine
This is Rietveld 408576698