Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(712)

Side by Side Diff: content/renderer/media/media_stream_impl.cc

Issue 10177008: Shift media_stream::StreamOptions to align with the new getUserMedia spec (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: rebase Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/renderer/media/media_stream_impl.h" 5 #include "content/renderer/media/media_stream_impl.h"
6 6
7 #include <utility> 7 #include <utility>
8 8
9 #include "base/bind.h" 9 #include "base/bind.h"
10 #include "base/logging.h" 10 #include "base/logging.h"
(...skipping 165 matching lines...) Expand 10 before | Expand all | Expand 10 after
176 const WebKit::WebVector<WebKit::WebMediaStreamSource>& video_sources) { 176 const WebKit::WebVector<WebKit::WebMediaStreamSource>& video_sources) {
177 // Save histogram data so we can see how much GetUserMedia is used. 177 // Save histogram data so we can see how much GetUserMedia is used.
178 // The histogram counts the number of calls to the JS API 178 // The histogram counts the number of calls to the JS API
179 // webGetUserMedia. 179 // webGetUserMedia.
180 UMA_HISTOGRAM_COUNTS_100(kHistogramGetUserMedia, 1); 180 UMA_HISTOGRAM_COUNTS_100(kHistogramGetUserMedia, 1);
181 DCHECK(CalledOnValidThread()); 181 DCHECK(CalledOnValidThread());
182 DCHECK(!user_media_request.isNull()); 182 DCHECK(!user_media_request.isNull());
183 int request_id = g_next_request_id++; 183 int request_id = g_next_request_id++;
184 184
185 bool audio = user_media_request.audio(); 185 bool audio = user_media_request.audio();
186 media_stream::StreamOptions::VideoOption video_option = 186 bool video = user_media_request.video();
187 media_stream::StreamOptions::kNoCamera;
188 if (user_media_request.video())
189 video_option = media_stream::StreamOptions::kFacingBoth;
190 187
191 std::string security_origin = UTF16ToUTF8( 188 std::string security_origin = UTF16ToUTF8(
192 user_media_request.securityOrigin().toString()); 189 user_media_request.securityOrigin().toString());
193 190
194 DVLOG(1) << "MediaStreamImpl::generateStream(" << request_id << ", [ " 191 DVLOG(1) << "MediaStreamImpl::generateStream(" << request_id << ", [ "
195 << (audio ? "audio" : "") 192 << (audio ? "audio" : "")
196 << (user_media_request.video() ? " video" : "") << "], " 193 << (user_media_request.video() ? " video" : "") << "], "
197 << security_origin << ")"; 194 << security_origin << ")";
198 195
199 user_media_requests_.insert( 196 user_media_requests_.insert(
200 std::pair<int, WebKit::WebUserMediaRequest>( 197 std::pair<int, WebKit::WebUserMediaRequest>(
201 request_id, user_media_request)); 198 request_id, user_media_request));
202 199
203 media_stream_dispatcher_->GenerateStream( 200 media_stream_dispatcher_->GenerateStream(
204 request_id, 201 request_id,
205 AsWeakPtr(), 202 AsWeakPtr(),
206 media_stream::StreamOptions(audio, video_option), 203 media_stream::StreamOptions(audio, video),
207 security_origin); 204 security_origin);
208 } 205 }
209 206
210 void MediaStreamImpl::cancelUserMediaRequest( 207 void MediaStreamImpl::cancelUserMediaRequest(
211 const WebKit::WebUserMediaRequest& user_media_request) { 208 const WebKit::WebUserMediaRequest& user_media_request) {
212 DCHECK(CalledOnValidThread()); 209 DCHECK(CalledOnValidThread());
213 // TODO(grunell): Implement. 210 // TODO(grunell): Implement.
214 NOTIMPLEMENTED(); 211 NOTIMPLEMENTED();
215 } 212 }
216 213
(...skipping 302 matching lines...) Expand 10 before | Expand all | Expand 10 after
519 return rtc_video_decoder; 516 return rtc_video_decoder;
520 } 517 }
521 518
522 MediaStreamImpl::VideoRendererWrapper::VideoRendererWrapper( 519 MediaStreamImpl::VideoRendererWrapper::VideoRendererWrapper(
523 RTCVideoDecoder* decoder) 520 RTCVideoDecoder* decoder)
524 : rtc_video_decoder_(decoder) { 521 : rtc_video_decoder_(decoder) {
525 } 522 }
526 523
527 MediaStreamImpl::VideoRendererWrapper::~VideoRendererWrapper() { 524 MediaStreamImpl::VideoRendererWrapper::~VideoRendererWrapper() {
528 } 525 }
OLDNEW
« no previous file with comments | « content/renderer/media/media_stream_dispatcher_unittest.cc ('k') | content/renderer/media/mock_media_stream_dispatcher.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698