Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10177007: Add buffer to capture crash in ExtensionAPI::LoadSchemaList (Closed)

Created:
8 years, 8 months ago by not at google - send to devlin
Modified:
8 years, 7 months ago
CC:
chromium-reviews, Aaron Boodman, mihaip+watch_chromium.org, benwells, koz (OOO until 15th September)
Visibility:
Public.

Description

Add buffer to capture crash in ExtensionAPI::LoadSchemaList BUG=121424 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=134513

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : rebase #

Total comments: 2

Patch Set 4 : koz #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -6 lines) Patch
M chrome/common/extensions/api/extension_api.h View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/api/extension_api.cc View 1 2 3 5 chunks +17 lines, -5 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
not at google - send to devlin
8 years, 7 months ago (2012-04-30 00:01:18 UTC) #1
koz (OOO until 15th September)
lgtm http://codereview.chromium.org/10177007/diff/3002/chrome/common/extensions/api/extension_api.cc File chrome/common/extensions/api/extension_api.cc (right): http://codereview.chromium.org/10177007/diff/3002/chrome/common/extensions/api/extension_api.cc#newcode729 chrome/common/extensions/api/extension_api.cc:729: std::map<std::string, base::StringPiece>::iterator next = nit: next -> it
8 years, 7 months ago (2012-04-30 01:18:41 UTC) #2
not at google - send to devlin
http://codereview.chromium.org/10177007/diff/3002/chrome/common/extensions/api/extension_api.cc File chrome/common/extensions/api/extension_api.cc (right): http://codereview.chromium.org/10177007/diff/3002/chrome/common/extensions/api/extension_api.cc#newcode729 chrome/common/extensions/api/extension_api.cc:729: std::map<std::string, base::StringPiece>::iterator next = On 2012/04/30 01:18:41, koz wrote: ...
8 years, 7 months ago (2012-04-30 04:43:32 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kalman@chromium.org/10177007/6003
8 years, 7 months ago (2012-04-30 04:43:45 UTC) #4
commit-bot: I haz the power
8 years, 7 months ago (2012-04-30 07:11:18 UTC) #5 
Change committed as 134513

Powered by Google App Engine
This is Rietveld 408576698