Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Issue 10177003: Font Settings Extension API: Add functions to clear prefs. (Closed)

Created:
8 years, 8 months ago by falken
Modified:
8 years, 8 months ago
Reviewers:
Matt Perry
CC:
chromium-reviews, Aaron Boodman, mihaip+watch_chromium.org
Visibility:
Public.

Description

Font Settings Extension API: Add functions to clear prefs. BUG=114148 TEST=browser_tests --gtest_filter=ExtensionApiTest.FontSettings Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=133638

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+796 lines, -12 lines) Patch
M chrome/browser/extensions/extension_font_settings_api.h View 6 chunks +53 lines, -0 lines 0 comments Download
M chrome/browser/extensions/extension_font_settings_api.cc View 6 chunks +42 lines, -0 lines 0 comments Download
M chrome/browser/extensions/extension_font_settings_apitest.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M chrome/browser/extensions/extension_function_registry.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/common/extensions/api/experimental.fontSettings.json View 8 chunks +105 lines, -6 lines 0 comments Download
M chrome/common/extensions/docs/experimental.fontSettings.html View 8 chunks +489 lines, -6 lines 0 comments Download
M chrome/common/extensions/docs/samples.json View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/test/data/extensions/api_test/font_settings/test.js View 2 chunks +90 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
falken
8 years, 8 months ago (2012-04-23 10:43:01 UTC) #1
Matt Perry
LGTM Not for this CL, but could you try using the json_schema_compiler? It will help ...
8 years, 8 months ago (2012-04-23 20:40:15 UTC) #2
falken
On 2012/04/23 20:40:15, Matt Perry wrote: > LGTM > > Not for this CL, but ...
8 years, 8 months ago (2012-04-24 04:09:35 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/falken@chromium.org/10177003/1
8 years, 8 months ago (2012-04-24 04:10:49 UTC) #4
commit-bot: I haz the power
8 years, 8 months ago (2012-04-24 05:57:27 UTC) #5
Change committed as 133638

Powered by Google App Engine
This is Rietveld 408576698