Do not include Ctrl+N and Ctrl+Shift+N in chrome/browser/ui/views/accelerator_table.cc when USE_ASH

Do not include Ctrl+N and Ctrl+Shift+N in chrome/browser/ui/views/accelerator_table.cc when USE_ASH is #defined.

The shortcuts should be excluded since they're already included in ash/accelerators/accelerator_table.cc. Removing this kind of duplication is necessary for implementing crbug.com/123856 correctly. Along with the change, add unit tests for preventing the same mistake in the future.

BUG=123856
TEST=ran unit_tests

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=133651

[Ben Goodger (Google), 2012-04-23 15:23:38]

lgtm

[mazda, 2012-04-23 16:13:23]

This causes the following regression.
http://code.google.com/p/chromium/issues/detail?id=120196

We need to come up with a way to list global shortcut keys to wrench menu item.

[Yusuke Sato, 2012-04-24 06:01:29]

Good catch! Thanks.

I think ToolbarView::GetAcceleratorForCommandId() would be the right place to
fix 120196. Let me do it in a separate CL.

On 2012/04/23 16:13:23, mazda wrote:
> This causes the following regression.
> http://code.google.com/p/chromium/issues/detail?id=120196
> 
> We need to come up with a way to list global shortcut keys to wrench menu
item.

[commit-bot: I haz the power, 2012-04-24 07:34:00]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yusukes@chromium.org/10177002/13001

[Yusuke Sato, 2012-04-24 07:40:02]

> Let me do it in a separate CL.

Started code review: http://codereview.chromium.org/10155022/

[commit-bot: I haz the power, 2012-04-24 08:53:36]

Change committed as 133651