Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(900)

Issue 10175010: Force a rescan when opening the Wifi menu on the settings page. (Closed)

Created:
8 years, 8 months ago by kevers
Modified:
8 years, 8 months ago
Reviewers:
csilv
CC:
chromium-reviews, arv (Not doing code reviews)
Visibility:
Public.

Description

Force a rescan when opening the Wifi menu on the settings page. BUG=123030 TEST=Manual. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=133820

Patch Set 1 #

Total comments: 2

Patch Set 2 : Simplify Callback name. #

Patch Set 3 : Merge with trunk #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -1 line) Patch
M chrome/browser/resources/options2/chromeos/network_list.js View 1 2 2 chunks +7 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/options2/chromeos/internet_options_handler2.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/options2/chromeos/internet_options_handler2.cc View 1 2 chunks +7 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
kevers
Hi Chris, Can you please have a look at this CL.
8 years, 8 months ago (2012-04-23 20:16:31 UTC) #1
csilv
lgtm http://codereview.chromium.org/10175010/diff/1/chrome/browser/ui/webui/options2/chromeos/internet_options_handler2.cc File chrome/browser/ui/webui/options2/chromeos/internet_options_handler2.cc (right): http://codereview.chromium.org/10175010/diff/1/chrome/browser/ui/webui/options2/chromeos/internet_options_handler2.cc#newcode439 chrome/browser/ui/webui/options2/chromeos/internet_options_handler2.cc:439: web_ui()->RegisterMessageCallback("buttonClickCallback", optional: I think the message strings would ...
8 years, 8 months ago (2012-04-24 17:15:54 UTC) #2
kevers
http://codereview.chromium.org/10175010/diff/1/chrome/browser/ui/webui/options2/chromeos/internet_options_handler2.cc File chrome/browser/ui/webui/options2/chromeos/internet_options_handler2.cc (right): http://codereview.chromium.org/10175010/diff/1/chrome/browser/ui/webui/options2/chromeos/internet_options_handler2.cc#newcode439 chrome/browser/ui/webui/options2/chromeos/internet_options_handler2.cc:439: web_ui()->RegisterMessageCallback("buttonClickCallback", On 2012/04/24 17:15:54, csilv wrote: > optional: I ...
8 years, 8 months ago (2012-04-24 17:46:13 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kevers@chromium.org/10175010/10001
8 years, 8 months ago (2012-04-24 21:15:03 UTC) #4
commit-bot: I haz the power
8 years, 8 months ago (2012-04-25 00:24:52 UTC) #5
Change committed as 133820

Powered by Google App Engine
This is Rietveld 408576698