Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Unified Diff: base/message_loop.cc

Issue 10174048: PPAPI/NaCl: Speculative implementation for ipc_channel_nacl.cc (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix some TODOs Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ipc/ipc_channel_nacl.h » ('j') | ipc/ipc_channel_nacl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/message_loop.cc
diff --git a/base/message_loop.cc b/base/message_loop.cc
index dd8ba3ad06891fd6d2409d36c94ced6ffa7f6310..a207659a4a922203a2e3850bbcdde4b1425dd21d 100644
--- a/base/message_loop.cc
+++ b/base/message_loop.cc
@@ -151,10 +151,12 @@ MessageLoop::MessageLoop(Type type)
#define MESSAGE_PUMP_UI base::MessagePumpMac::Create()
#define MESSAGE_PUMP_IO new base::MessagePumpLibevent()
#elif defined(OS_NACL)
-// Currently NaCl doesn't have a UI or an IO MessageLoop.
-// TODO(abarth): Figure out if we need these.
+// Currently NaCl doesn't have a UI MessageLoop.
+// TODO(abarth): Figure out if we need this.
#define MESSAGE_PUMP_UI NULL
-#define MESSAGE_PUMP_IO NULL
+// ipc_channel_nacl.cc uses a worker thread to do socket reads currently, and
+// doesn't require extra support for watching file descriptors.
+#define MESSAGE_PUMP_IO new base::MessagePumpDefault();
#elif defined(OS_POSIX) // POSIX but not MACOSX.
#define MESSAGE_PUMP_UI new base::MessagePumpForUI()
#define MESSAGE_PUMP_IO new base::MessagePumpLibevent()
« no previous file with comments | « no previous file | ipc/ipc_channel_nacl.h » ('j') | ipc/ipc_channel_nacl.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698