Implement a callout widget for the active panel.

Implement a callout widget for the active panel.

BUG=none
TEST=none


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=134431

[dcheng, 2012-04-26 01:23:26]

Basic version of the callout. Note that this change depends on a change still in
review: http://codereview.chromium.org/10173016/

One thing I've noticed is that when the drop shadow is animating in when you
switch windows, it ends up being drawn on top of the callout even though I've
ordered the callout to the top of the panel container's children. Is there a way
to prevent that from happening?

[sky, 2012-04-26 15:41:16]

I'm not sure what would cause the shadow to appear at the top. You'll have to
set some breakpoints in the layer code to see why the shadow gets ordered at the
top.

http://codereview.chromium.org/10174037/diff/1/ash/wm/panel_layout_manager.cc
File ash/wm/panel_layout_manager.cc (right):

http://codereview.chromium.org/10174037/diff/1/ash/wm/panel_layout_manager.cc...
ash/wm/panel_layout_manager.cc:42: class CalloutWidgetBackground : public
views::Background{
nit: space after Background

http://codereview.chromium.org/10174037/diff/1/ash/wm/panel_layout_manager.cc...
ash/wm/panel_layout_manager.cc:282: bounds.set_y(icon_origin.y() -
bounds.height() - 10);
Normal windows can sit flush to the launcher.

http://codereview.chromium.org/10174037/diff/1/ash/wm/panel_layout_manager.cc...
ash/wm/panel_layout_manager.cc:287: UpdateCallout(active_panel);
UpdateStacking might use last_active_panel_, does UpdateCallout need to do the
same?

http://codereview.chromium.org/10174037/diff/1/ash/wm/panel_layout_manager.cc...
ash/wm/panel_layout_manager.cc:346:
panel_container_->StackChildAtTop(callout_widget_->GetNativeWindow());
I would stack at top first, then show.

[dcheng, 2012-04-27 01:11:35]

I'm working on tests right now, but I think the functional part of this patch is
ready for review.

http://codereview.chromium.org/10174037/diff/1/ash/wm/panel_layout_manager.cc
File ash/wm/panel_layout_manager.cc (right):

http://codereview.chromium.org/10174037/diff/1/ash/wm/panel_layout_manager.cc...
ash/wm/panel_layout_manager.cc:42: class CalloutWidgetBackground : public
views::Background{
On 2012/04/26 15:41:16, sky wrote:
> nit: space after Background

Done.

http://codereview.chromium.org/10174037/diff/1/ash/wm/panel_layout_manager.cc...
ash/wm/panel_layout_manager.cc:282: bounds.set_y(icon_origin.y() -
bounds.height() - 10);
On 2012/04/26 15:41:16, sky wrote:
> Normal windows can sit flush to the launcher.

Right now, we're lining things up to the top of the icons which is why I added
this random padding. I've fixed this the right way. It still differs a bit from
normal top level windows however--if you drag a normal window as far down as you
can, it pops back up a bit after you let go of the mouse--I'm assuming this is
to make room for the resize border.

http://codereview.chromium.org/10174037/diff/1/ash/wm/panel_layout_manager.cc...
ash/wm/panel_layout_manager.cc:287: UpdateCallout(active_panel);
On 2012/04/26 15:41:16, sky wrote:
> UpdateStacking might use last_active_panel_, does UpdateCallout need to do the
> same?

No, we only want to decorate a panel with the callout widget if it's focused.

http://codereview.chromium.org/10174037/diff/1/ash/wm/panel_layout_manager.cc...
ash/wm/panel_layout_manager.cc:346:
panel_container_->StackChildAtTop(callout_widget_->GetNativeWindow());
On 2012/04/26 15:41:16, sky wrote:
> I would stack at top first, then show.

Done.

[sky, 2012-04-27 15:42:42]

LGTM

http://codereview.chromium.org/10174037/diff/12001/ash/wm/panel_layout_manager.h
File ash/wm/panel_layout_manager.h (right):

http://codereview.chromium.org/10174037/diff/12001/ash/wm/panel_layout_manage...
ash/wm/panel_layout_manager.h:95: // Don't call this directly. Only
UpdateCallout() should call this method.
nit: newline between 94/95. In fact typical style is newline between all members
below too.

[dcheng, 2012-04-27 22:20:14]

Added tests and cleaned up a few things here and there in the unit test as well.
I made all the test helpers class methods of PanelLayoutManagerTest just to keep
things grouped up even though most of them don't necessarily need access to the
members.

[sky, 2012-04-27 23:02:36]

LGTM

http://codereview.chromium.org/10174037/diff/17004/ash/wm/panel_layout_manager.h
File ash/wm/panel_layout_manager.h (right):

http://codereview.chromium.org/10174037/diff/17004/ash/wm/panel_layout_manage...
ash/wm/panel_layout_manager.h:93: // TODO(dcheng): Possibly a bug in the shadow
controller. If a window is
Please file a bug on this.

[commit-bot: I haz the power, 2012-04-27 23:10:19]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dcheng@chromium.org/10174037/17004

[commit-bot: I haz the power, 2012-04-27 23:32:10]

Try job failure for 10174037-17004 (retry) on win_rel for step "update".
It's a second try, previously, step "update" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

Step "update" is always a major failure.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2012-04-27 23:42:15]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dcheng@chromium.org/10174037/22002

[commit-bot: I haz the power, 2012-04-28 02:48:48]

Change committed as 134431